From f0be2134e577048c932c5810a7f8a30876bff665 Mon Sep 17 00:00:00 2001 From: Joe Onorato Date: Tue, 24 Nov 2009 19:34:29 -0500 Subject: [PATCH] Fix 2275513 - Icons don't update on package update Also reuses the BubbleText object, which was being recreated for no reason. --- src/com/android/launcher2/AllAppsList.java | 2 +- src/com/android/launcher2/AppInfoCache.java | 5 +++-- src/com/android/launcher2/Launcher.java | 1 + 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/com/android/launcher2/AllAppsList.java b/src/com/android/launcher2/AllAppsList.java index 4d3ee77ecf..561b34597d 100644 --- a/src/com/android/launcher2/AllAppsList.java +++ b/src/com/android/launcher2/AllAppsList.java @@ -152,7 +152,7 @@ class AllAppsList { data.add(applicationInfo); added.add(applicationInfo); } else { - AppInfoCache.update(info, applicationInfo, context); + AppInfoCache.update(info, applicationInfo, context, bubble); modified.add(applicationInfo); } } diff --git a/src/com/android/launcher2/AppInfoCache.java b/src/com/android/launcher2/AppInfoCache.java index 2fdfc284ad..a2d98307ff 100644 --- a/src/com/android/launcher2/AppInfoCache.java +++ b/src/com/android/launcher2/AppInfoCache.java @@ -86,9 +86,10 @@ public class AppInfoCache { /** * Update the entry in the in the cache with its new metadata. */ - public static void update(ResolveInfo info, ApplicationInfo applicationInfo, Context context) { + public static void update(ResolveInfo info, ApplicationInfo applicationInfo, Context context, + Utilities.BubbleText bubble) { synchronized (sCache) { - updateTitleAndIcon(info, applicationInfo, context, new Utilities.BubbleText(context)); + updateTitleAndIcon(info, applicationInfo, context, bubble); ComponentName componentName = new ComponentName( info.activityInfo.applicationInfo.packageName, info.activityInfo.name); diff --git a/src/com/android/launcher2/Launcher.java b/src/com/android/launcher2/Launcher.java index 0e1ae7d7b3..d2fd6a9fef 100644 --- a/src/com/android/launcher2/Launcher.java +++ b/src/com/android/launcher2/Launcher.java @@ -2222,6 +2222,7 @@ public final class Launcher extends Activity public void bindPackageUpdated(String packageName, ArrayList apps) { removeDialog(DIALOG_CREATE_SHORTCUT); mWorkspace.updateShortcutsForPackage(packageName); + mAllAppsGrid.updateApps(packageName, apps); } /**