From e880ccfa2f21b7602815eb97bb22b58c567ecf8e Mon Sep 17 00:00:00 2001 From: Alex Chau Date: Fri, 24 Jan 2025 18:31:55 +0000 Subject: [PATCH] Rename OverviewProxyService to LauncherProxyService - OverviewProxyService is a shared service to send information from SysUI to Launcher, only 1 method `onOverviewShown` is related to Overview, renaming this service to better reflect the nature to avoid bugs misrouted to Overview component. Fix: 391563516 Test: presubmit Flag: EXEMPT REFACTOR Change-Id: I7104532daa1a4b6a7a39966f11063fbe9d15533e --- quickstep/src/com/android/quickstep/SystemUiProxy.kt | 2 +- .../com/android/quickstep/TouchInteractionService.java | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/quickstep/src/com/android/quickstep/SystemUiProxy.kt b/quickstep/src/com/android/quickstep/SystemUiProxy.kt index 87953c703b..d5382ad21a 100644 --- a/quickstep/src/com/android/quickstep/SystemUiProxy.kt +++ b/quickstep/src/com/android/quickstep/SystemUiProxy.kt @@ -126,7 +126,7 @@ class SystemUiProxy @Inject constructor(@ApplicationContext private val context: private val systemUiProxyDeathRecipient = IBinder.DeathRecipient { Executors.MAIN_EXECUTOR.execute { clearProxy() } } - // Save the listeners passed into the proxy since OverviewProxyService may not have been bound + // Save the listeners passed into the proxy since LauncherProxyService may not have been bound // yet, and we'll need to set/register these listeners with SysUI when they do. Note that it is // up to the caller to clear the listeners to prevent leaks as these can be held indefinitely // in case SysUI needs to rebind. diff --git a/quickstep/src/com/android/quickstep/TouchInteractionService.java b/quickstep/src/com/android/quickstep/TouchInteractionService.java index 33ba780a0a..516b24caa1 100644 --- a/quickstep/src/com/android/quickstep/TouchInteractionService.java +++ b/quickstep/src/com/android/quickstep/TouchInteractionService.java @@ -100,7 +100,7 @@ import com.android.quickstep.util.ActivityPreloadUtil; import com.android.quickstep.util.ContextualSearchInvoker; import com.android.quickstep.util.ContextualSearchStateManager; import com.android.quickstep.views.RecentsViewContainer; -import com.android.systemui.shared.recents.IOverviewProxy; +import com.android.systemui.shared.recents.ILauncherProxy; import com.android.systemui.shared.recents.ISystemUiProxy; import com.android.systemui.shared.statusbar.phone.BarTransitions; import com.android.systemui.shared.system.InputChannelCompat.InputEventReceiver; @@ -141,9 +141,9 @@ public class TouchInteractionService extends Service { private final TISBinder mTISBinder = new TISBinder(this); /** - * Local IOverviewProxy implementation with some methods for local components + * Local ILauncherProxy implementation with some methods for local components */ - public static class TISBinder extends IOverviewProxy.Stub { + public static class TISBinder extends ILauncherProxy.Stub { private final WeakReference mTis; @@ -423,7 +423,7 @@ public class TouchInteractionService extends Service { try { reply.sendResult(null); } catch (RemoteException e) { - Log.w(TAG, "onUnbind: Failed to reply to OverviewProxyService", e); + Log.w(TAG, "onUnbind: Failed to reply to LauncherProxyService", e); } }); }