From df3632daaef940f1c22eae8a85a6aee77faf0549 Mon Sep 17 00:00:00 2001 From: SuperDragonXD <70206496+SuperDragonXD@users.noreply.github.com> Date: Sat, 2 Aug 2025 18:01:14 +0800 Subject: [PATCH] refactor(about): migrate screen to ViewModel and UDF (#5698) * feat(about): add viewmodel and UDF state models * feat(about): add new repository and service * feat(about): refactor About screen and related components * refactor(about): remove legacy update checker file * refactor(about): improve robustness of NightlyBuildsRepository This change also tweaks the code to use application storage instead of external storage. * refactor(acknowledgements): simplify Acknowledgements implementation * fix(about): add missing strings * refactor(acknowledgements): apply suggestions from review * refactor(about): simplify nightly builds repository * refactor(about): apply changes from review * refactor(acknowledgements): apply changes from review * fixup: apply review suggestions from Goooler --- lawnchair/res/values/strings.xml | 4 + lawnchair/res/xml/provider_paths.xml | 1 + .../src/app/lawnchair/api/gh/GitHubApi.kt | 57 --- .../ui/preferences/PreferenceInteractor.kt | 2 - .../ui/preferences/PreferenceViewModel.kt | 17 - .../lawnchair/ui/preferences/about/About.kt | 375 ++++++------------ .../ui/preferences/about/AboutModels.kt | 146 +++++++ .../ui/preferences/about/AboutViewModel.kt | 207 ++++++++++ .../ui/preferences/about/ContributorRow.kt | 98 ++--- .../ui/preferences/about/GithubService.kt | 94 +++++ .../about/NightlyBuildsRepository.kt | 168 ++++++++ .../ui/preferences/about/UpdateSection.kt | 77 ++++ .../acknowledgements/Acknowledgements.kt | 130 ++---- .../AcknowledgementsViewModel.kt | 51 +++ .../about/acknowledgements/LoadNotice.kt | 92 ----- .../about/acknowledgements/OssLibrary.kt | 36 ++ .../ui/preferences/components/CheckUpdate.kt | 202 ---------- 17 files changed, 997 insertions(+), 760 deletions(-) delete mode 100644 lawnchair/src/app/lawnchair/api/gh/GitHubApi.kt create mode 100644 lawnchair/src/app/lawnchair/ui/preferences/about/AboutModels.kt create mode 100644 lawnchair/src/app/lawnchair/ui/preferences/about/AboutViewModel.kt create mode 100644 lawnchair/src/app/lawnchair/ui/preferences/about/GithubService.kt create mode 100644 lawnchair/src/app/lawnchair/ui/preferences/about/NightlyBuildsRepository.kt create mode 100644 lawnchair/src/app/lawnchair/ui/preferences/about/UpdateSection.kt create mode 100644 lawnchair/src/app/lawnchair/ui/preferences/about/acknowledgements/AcknowledgementsViewModel.kt delete mode 100644 lawnchair/src/app/lawnchair/ui/preferences/about/acknowledgements/LoadNotice.kt create mode 100644 lawnchair/src/app/lawnchair/ui/preferences/about/acknowledgements/OssLibrary.kt delete mode 100644 lawnchair/src/app/lawnchair/ui/preferences/components/CheckUpdate.kt diff --git a/lawnchair/res/values/strings.xml b/lawnchair/res/values/strings.xml index 07d547f745..029d485dba 100644 --- a/lawnchair/res/values/strings.xml +++ b/lawnchair/res/values/strings.xml @@ -457,6 +457,10 @@ Translate Donate + Active + + Failed to check for updates +