From dc016f37a29b42fe3b825acde0529a2e39471a18 Mon Sep 17 00:00:00 2001 From: Samuel Fufa Date: Tue, 9 Mar 2021 09:57:40 -0600 Subject: [PATCH] Fix QSB tap crash Launcher should use LCM of supported getSupportedItemsPerRowArray instead of product. Bug: 182236647 Test: Manual Change-Id: Ia0ad1158a841068c29ed09bf7f598f14c410092f --- src/com/android/launcher3/allapps/AllAppsGridAdapter.java | 6 ++++-- .../launcher3/allapps/search/SearchAdapterProvider.java | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/com/android/launcher3/allapps/AllAppsGridAdapter.java b/src/com/android/launcher3/allapps/AllAppsGridAdapter.java index a05e036701..bb175eac28 100644 --- a/src/com/android/launcher3/allapps/AllAppsGridAdapter.java +++ b/src/com/android/launcher3/allapps/AllAppsGridAdapter.java @@ -290,8 +290,10 @@ public class AllAppsGridAdapter extends public void setAppsPerRow(int appsPerRow) { mAppsPerRow = appsPerRow; int totalSpans = mAppsPerRow; - for (int itemPerRow : mSearchAdapterProvider.getSupportedItemsPerRow()) { - totalSpans *= itemPerRow; + for (int itemPerRow : mSearchAdapterProvider.getSupportedItemsPerRowArray()) { + if (totalSpans % itemPerRow != 0) { + totalSpans *= itemPerRow; + } } mGridLayoutMgr.setSpanCount(totalSpans); } diff --git a/src/com/android/launcher3/allapps/search/SearchAdapterProvider.java b/src/com/android/launcher3/allapps/search/SearchAdapterProvider.java index 6d491fdd2e..fdacd3d2d9 100644 --- a/src/com/android/launcher3/allapps/search/SearchAdapterProvider.java +++ b/src/com/android/launcher3/allapps/search/SearchAdapterProvider.java @@ -53,7 +53,7 @@ public abstract class SearchAdapterProvider { /** * Returns supported item per row combinations supported */ - public int[] getSupportedItemsPerRow() { + public int[] getSupportedItemsPerRowArray() { return new int[]{}; }