From ce3bbc7b5ed5a4412077f17ebdb7f5db452d007b Mon Sep 17 00:00:00 2001 From: Liran Binyamin Date: Mon, 10 Jun 2024 10:17:13 -0400 Subject: [PATCH] Fix state after dragging bubble to dismiss After dragging a bubble in the bubble bar to dismiss it, we remove it from the view and update the width of the bubble bar. The issue here is that the drag state only gets cleared in BubbleBarView after the dismiss animation is complete, so when the width is updated, we don't reposition all the bubbles according to the new width, and end up in a weird state. The fix is to clear the drag state in onDragDismiss. Flag: com.android.wm.shell.enable_bubble_bar Fixes: 345482103 Test: manual - Add multiple bubbles to the bubble bar - Drag a bubble to dismiss it - Observe bubble bar updates correctly - Repeat with other bubbles Change-Id: Ie94f8ace0f5660466686a261174b42c8d71b3e30 --- .../android/launcher3/taskbar/bubbles/BubbleDragController.java | 1 + 1 file changed, 1 insertion(+) diff --git a/quickstep/src/com/android/launcher3/taskbar/bubbles/BubbleDragController.java b/quickstep/src/com/android/launcher3/taskbar/bubbles/BubbleDragController.java index fbd1b88693..efc747c725 100644 --- a/quickstep/src/com/android/launcher3/taskbar/bubbles/BubbleDragController.java +++ b/quickstep/src/com/android/launcher3/taskbar/bubbles/BubbleDragController.java @@ -153,6 +153,7 @@ public class BubbleDragController { @Override protected void onDragDismiss() { mBubblePinController.onDragEnd(); + mBubbleBarViewController.onBubbleDragEnd(); } @Override