From c5e49022bea70a1b0b6ada5431afbb6e951cc3f6 Mon Sep 17 00:00:00 2001 From: Michael Jurka Date: Wed, 16 Feb 2011 12:04:02 -0800 Subject: [PATCH] Simplifying logic to create/destroy hardware layers in All Apps Bug # 3422984 --- src/com/android/launcher2/AllAppsPagedView.java | 1 + src/com/android/launcher2/PagedView.java | 14 -------------- src/com/android/launcher2/PagedViewCellLayout.java | 1 + 3 files changed, 2 insertions(+), 14 deletions(-) diff --git a/src/com/android/launcher2/AllAppsPagedView.java b/src/com/android/launcher2/AllAppsPagedView.java index daa5d64036..1e4821aa8f 100644 --- a/src/com/android/launcher2/AllAppsPagedView.java +++ b/src/com/android/launcher2/AllAppsPagedView.java @@ -515,6 +515,7 @@ public class AllAppsPagedView extends PagedViewWithDraggableItems implements All layout.addViewToCellLayout(icon, -1, 0, new PagedViewCellLayout.LayoutParams(0, 0, 4, 1)); } + layout.createHardwareLayers(); } /* diff --git a/src/com/android/launcher2/PagedView.java b/src/com/android/launcher2/PagedView.java index 05e4086cf4..cb0d4ba01a 100644 --- a/src/com/android/launcher2/PagedView.java +++ b/src/com/android/launcher2/PagedView.java @@ -597,21 +597,7 @@ public abstract class PagedView extends ViewGroup { canvas.clipRect(mScrollX, mScrollY, mScrollX + mRight - mLeft, mScrollY + mBottom - mTop); - for (int i = 0; i < pageCount; i++) { - View child = getChildAt(i); - if (child != null && child instanceof PagedViewCellLayout) { - boolean willBeDrawn = i >= leftScreen && i <= rightScreen; - if (!willBeDrawn) { - ((PagedViewCellLayout)child).destroyHardwareLayers(); - } - } - } - for (int i = leftScreen; i <= rightScreen; i++) { - View child = getChildAt(i); - if (child != null && child instanceof PagedViewCellLayout) { - ((PagedViewCellLayout)child).createHardwareLayers(); - } drawChild(canvas, getChildAt(i), drawingTime); } canvas.restore(); diff --git a/src/com/android/launcher2/PagedViewCellLayout.java b/src/com/android/launcher2/PagedViewCellLayout.java index d64f3c901a..57d41fafff 100644 --- a/src/com/android/launcher2/PagedViewCellLayout.java +++ b/src/com/android/launcher2/PagedViewCellLayout.java @@ -141,6 +141,7 @@ public class PagedViewCellLayout extends ViewGroup implements Page { public void removeAllViewsOnPage() { mChildren.removeAllViews(); mHolographicChildren.removeAllViews(); + destroyHardwareLayers(); } @Override