From 8b65ad809ef7c16ba6aa8b9a1342bab564c879c4 Mon Sep 17 00:00:00 2001 From: samcackett Date: Mon, 14 Apr 2025 17:31:39 +0100 Subject: [PATCH] Decouple actionsView disabled state from clearAllButton visibility Prior to this change, actionsView buttons enabled / disabled state was coupled to clearAllButton visibility, which was then coupled to scroll state. Due to an issue where outdated scroll values caused incorrect visibility calculations for the "clear all" button and consequently disabled the overview actions, we remove this check. Fix: 391276638 Flag: EXEMPT. Bugfix Test: Manual & TaplTestsQuickstep Change-Id: Ib313deb72e8f01125f15f62e7e9a4af307062060 --- quickstep/src/com/android/quickstep/views/RecentsView.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/quickstep/src/com/android/quickstep/views/RecentsView.java b/quickstep/src/com/android/quickstep/views/RecentsView.java index fd215674d1..147f0fced8 100644 --- a/quickstep/src/com/android/quickstep/views/RecentsView.java +++ b/quickstep/src/com/android/quickstep/views/RecentsView.java @@ -1702,7 +1702,7 @@ public abstract class RecentsView< protected void onPageEndTransition() { super.onPageEndTransition(); ActiveGestureProtoLogProxy.logOnPageEndTransition(getNextPage()); - if (isClearAllHidden() && !mContainer.getDeviceProfile().isTablet) { + if (!mContainer.getDeviceProfile().isTablet) { mActionsView.updateDisabledFlags(OverviewActionsView.DISABLED_SCROLLING, false); } if (getNextPage() > 0) { @@ -4235,7 +4235,7 @@ public abstract class RecentsView< // Update various scroll-dependent UI. dispatchScrollChanged(); updateActionsViewFocusedScroll(); - if (isClearAllHidden() && !mContainer.getDeviceProfile().isTablet) { + if (!mContainer.getDeviceProfile().isTablet) { mActionsView.updateDisabledFlags(OverviewActionsView.DISABLED_SCROLLING, false); }