From 29f6b0ba05b4f12230517f1f19757be027b6e628 Mon Sep 17 00:00:00 2001 From: Steven Ng Date: Fri, 16 Apr 2021 17:11:47 +0100 Subject: [PATCH] Add debug logs for widget recommendation down scale calculation Bug: 185508758 Test: None Change-Id: I0b4789075bcc5ffc26f30dcd483f7c97bee9f410 --- .../android/launcher3/widget/picker/WidgetsFullSheet.java | 5 +++++ .../widget/picker/WidgetsRecommendationTableLayout.java | 3 +++ 2 files changed, 8 insertions(+) diff --git a/src/com/android/launcher3/widget/picker/WidgetsFullSheet.java b/src/com/android/launcher3/widget/picker/WidgetsFullSheet.java index 90cd515349..70127c5354 100644 --- a/src/com/android/launcher3/widget/picker/WidgetsFullSheet.java +++ b/src/com/android/launcher3/widget/picker/WidgetsFullSheet.java @@ -28,6 +28,7 @@ import android.graphics.Rect; import android.os.Process; import android.os.UserHandle; import android.util.AttributeSet; +import android.util.Log; import android.util.Pair; import android.util.SparseArray; import android.view.LayoutInflater; @@ -461,6 +462,10 @@ public class WidgetsFullSheet extends BaseWidgetSheet WidgetsRecommendationTableLayout table = mSearchAndRecommendationViewHolder.mRecommendedWidgetsTable; if (recommendedWidgets.size() > 0) { + // TODO(b/185508758): Revert the following log after debugging. + if (getHeaderViewHeight() == 0) { + Log.d(TAG, "Header view height is 0 when inflating recommended widgets"); + } float maxTableHeight = (mLauncher.getDeviceProfile().heightPx - mTabsHeight - getHeaderViewHeight()) * RECOMMENDATION_TABLE_HEIGHT_RATIO; diff --git a/src/com/android/launcher3/widget/picker/WidgetsRecommendationTableLayout.java b/src/com/android/launcher3/widget/picker/WidgetsRecommendationTableLayout.java index b95bb16bdf..1bfffc29fc 100644 --- a/src/com/android/launcher3/widget/picker/WidgetsRecommendationTableLayout.java +++ b/src/com/android/launcher3/widget/picker/WidgetsRecommendationTableLayout.java @@ -89,6 +89,9 @@ public final class WidgetsRecommendationTableLayout extends TableLayout { mRecommendationTableMaxHeight = recommendationTableMaxHeight; RecommendationTableData data = fitRecommendedWidgetsToTableSpace(/* previewScale= */ 1f, recommendedWidgets); + // TODO(b/185508758): Revert the following logs after debugging. + Log.d(TAG, "Recommended widgets section max height: " + recommendationTableMaxHeight); + Log.d(TAG, "Recommended widget down scale: " + data.mPreviewScale); bindData(data); }