From d0fc718a0ace6c76057a0d7227bc1544da259cf1 Mon Sep 17 00:00:00 2001 From: Vinit Nayak Date: Fri, 6 Oct 2023 16:05:54 -0700 Subject: [PATCH] Dismiss split selection for workspace long-press Bug: 295426148 Test: Enter split contextual from homescreen, long-press on empty space, split gets dismissed Flag: ENABLE_SPLIT_WORKSPACE_TO_WORKSPACE Change-Id: I3a893bea7b22645fe60c65c4c5ab8c2087d769da --- .../android/launcher3/uioverrides/QuickstepLauncher.java | 7 +++++++ src/com/android/launcher3/Launcher.java | 5 +++++ .../android/launcher3/touch/WorkspaceTouchListener.java | 5 +++++ 3 files changed, 17 insertions(+) diff --git a/quickstep/src/com/android/launcher3/uioverrides/QuickstepLauncher.java b/quickstep/src/com/android/launcher3/uioverrides/QuickstepLauncher.java index 0497890154..e61a2c95c6 100644 --- a/quickstep/src/com/android/launcher3/uioverrides/QuickstepLauncher.java +++ b/quickstep/src/com/android/launcher3/uioverrides/QuickstepLauncher.java @@ -988,6 +988,13 @@ public class QuickstepLauncher extends Launcher { .playPlaceholderDismissAnim(this); } + @Override + public void dismissSplitSelection() { + super.dismissSplitSelection(); + mSplitSelectStateController.getSplitAnimationController() + .playPlaceholderDismissAnim(this); + } + public T getActionsView() { return (T) mActionsView; } diff --git a/src/com/android/launcher3/Launcher.java b/src/com/android/launcher3/Launcher.java index b34a527cde..d39bc1cfa5 100644 --- a/src/com/android/launcher3/Launcher.java +++ b/src/com/android/launcher3/Launcher.java @@ -3108,6 +3108,11 @@ public class Launcher extends StatefulActivity return false; } + /** Call to dismiss the intermediary split selection state. */ + public void dismissSplitSelection() { + // Overridden; move this into ActivityContext if necessary for Taskbar + } + @Override public void returnToHomescreen() { super.returnToHomescreen(); diff --git a/src/com/android/launcher3/touch/WorkspaceTouchListener.java b/src/com/android/launcher3/touch/WorkspaceTouchListener.java index 96ae4a32fd..1232069f59 100644 --- a/src/com/android/launcher3/touch/WorkspaceTouchListener.java +++ b/src/com/android/launcher3/touch/WorkspaceTouchListener.java @@ -40,6 +40,7 @@ import com.android.launcher3.CellLayout; import com.android.launcher3.DeviceProfile; import com.android.launcher3.Launcher; import com.android.launcher3.Workspace; +import com.android.launcher3.config.FeatureFlags; import com.android.launcher3.dragndrop.DragLayer; import com.android.launcher3.logger.LauncherAtom; import com.android.launcher3.testing.TestLogging; @@ -205,6 +206,10 @@ public class WorkspaceTouchListener extends GestureDetector.SimpleOnGestureListe HapticFeedbackConstants.FLAG_IGNORE_VIEW_SETTING); mLauncher.getStatsLogManager().logger().log(LAUNCHER_WORKSPACE_LONGPRESS); mLauncher.showDefaultOptions(mTouchDownPoint.x, mTouchDownPoint.y); + if (FeatureFlags.ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE.get() && + mLauncher.isSplitSelectionEnabled()) { + mLauncher.dismissSplitSelection(); + } } else { cancelLongPress(); }