From 8869bb5f40d9a62fc16290ed85e251660368e789 Mon Sep 17 00:00:00 2001 From: Evan Rosky Date: Thu, 30 Mar 2023 15:28:43 -0700 Subject: [PATCH] Improve transition logging Adding debug-names to remote transitions so that they can be identified across processes Bug: 276349701 Test: existing tests since this doesn't change logic Change-Id: I41400feeb2dd91971f8c750613085c80af309aea --- .../com/android/launcher3/QuickstepTransitionManager.java | 4 ++-- quickstep/src/com/android/quickstep/RecentsActivity.java | 6 ++++-- .../android/quickstep/util/SplitSelectStateController.java | 3 ++- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/quickstep/src/com/android/launcher3/QuickstepTransitionManager.java b/quickstep/src/com/android/launcher3/QuickstepTransitionManager.java index 8baa324a2a..9bc6f53874 100644 --- a/quickstep/src/com/android/launcher3/QuickstepTransitionManager.java +++ b/quickstep/src/com/android/launcher3/QuickstepTransitionManager.java @@ -321,7 +321,7 @@ public class QuickstepTransitionManager implements OnDeviceProfileChangeListener ActivityOptions options = ActivityOptions.makeRemoteAnimation( new RemoteAnimationAdapter(runner, duration, statusBarTransitionDelay), new RemoteTransition(runner.toRemoteTransition(), - mLauncher.getIApplicationThread())); + mLauncher.getIApplicationThread(), "QuickstepLaunch")); return new ActivityOptionsWrapper(options, onEndCallback); } @@ -1122,7 +1122,7 @@ public class QuickstepTransitionManager implements OnDeviceProfileChangeListener mLauncherOpenTransition = new RemoteTransition( new LauncherAnimationRunner(mHandler, mWallpaperOpenTransitionRunner, false /* startAtFrontOfQueue */).toRemoteTransition(), - mLauncher.getIApplicationThread()); + mLauncher.getIApplicationThread(), "QuickstepLaunchHome"); TransitionFilter homeCheck = new TransitionFilter(); // No need to handle the transition that also dismisses keyguard. diff --git a/quickstep/src/com/android/quickstep/RecentsActivity.java b/quickstep/src/com/android/quickstep/RecentsActivity.java index 3f8da56de4..253341df1a 100644 --- a/quickstep/src/com/android/quickstep/RecentsActivity.java +++ b/quickstep/src/com/android/quickstep/RecentsActivity.java @@ -267,7 +267,8 @@ public final class RecentsActivity extends StatefulActivity { new RemoteAnimationAdapter(wrapper, RECENTS_LAUNCH_DURATION, RECENTS_LAUNCH_DURATION - STATUS_BAR_TRANSITION_DURATION - STATUS_BAR_TRANSITION_PRE_DELAY), - new RemoteTransition(wrapper.toRemoteTransition(), getIApplicationThread())); + new RemoteTransition(wrapper.toRemoteTransition(), getIApplicationThread(), + "LaunchFromRecents")); final ActivityOptionsWrapper activityOptions = new ActivityOptionsWrapper(options, onEndCallback); activityOptions.options.setSplashScreenStyle(SplashScreen.SPLASH_SCREEN_STYLE_ICON); @@ -405,7 +406,8 @@ public final class RecentsActivity extends StatefulActivity { getMainThreadHandler(), mAnimationToHomeFactory, true); ActivityOptions options = ActivityOptions.makeRemoteAnimation( new RemoteAnimationAdapter(runner, HOME_APPEAR_DURATION, 0), - new RemoteTransition(runner.toRemoteTransition(), getIApplicationThread())); + new RemoteTransition(runner.toRemoteTransition(), getIApplicationThread(), + "StartHomeFromRecents")); startHomeIntentSafely(this, options.toBundle()); } diff --git a/quickstep/src/com/android/quickstep/util/SplitSelectStateController.java b/quickstep/src/com/android/quickstep/util/SplitSelectStateController.java index 00d6571f3c..c537ef88d7 100644 --- a/quickstep/src/com/android/quickstep/util/SplitSelectStateController.java +++ b/quickstep/src/com/android/quickstep/util/SplitSelectStateController.java @@ -284,7 +284,8 @@ public class SplitSelectStateController { final RemoteSplitLaunchTransitionRunner animationRunner = new RemoteSplitLaunchTransitionRunner(taskId1, taskId2, callback); final RemoteTransition remoteTransition = new RemoteTransition(animationRunner, - ActivityThread.currentActivityThread().getApplicationThread()); + ActivityThread.currentActivityThread().getApplicationThread(), + "LaunchSplitPair"); if (intent1 == null && intent2 == null) { mSystemUiProxy.startTasks(taskId1, options1.toBundle(), taskId2, null /* options2 */, stagePosition, splitRatio, remoteTransition,