From ae4f575911d0c17de8d687a8fa092b0aa8360243 Mon Sep 17 00:00:00 2001 From: Romain Guy Date: Thu, 11 Jun 2009 11:12:51 -0700 Subject: [PATCH] Improve the threading model in the gestures settings activity. This change checks for isCancelled() inside the loop to be able to terminate the thread as early as possible. --- src/com/android/launcher/GesturesActivity.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/com/android/launcher/GesturesActivity.java b/src/com/android/launcher/GesturesActivity.java index a112e1b5d3..c936576214 100644 --- a/src/com/android/launcher/GesturesActivity.java +++ b/src/com/android/launcher/GesturesActivity.java @@ -209,7 +209,7 @@ public class GesturesActivity extends ListActivity { adapter.sort(mSorter); checkForEmpty(); adapter.notifyDataSetChanged(); - + LauncherModel.deleteGestureFromDatabase(this, info); Toast.makeText(this, R.string.gestures_delete_success, Toast.LENGTH_SHORT).show(); @@ -239,6 +239,8 @@ public class GesturesActivity extends ListActivity { final LauncherModel model = Launcher.getModel(); for (String name : store.getGestureEntries()) { + if (isCancelled()) break; + final Gesture gesture = store.getGestures(name).get(0); final Bitmap bitmap = gesture.toBitmap(mThumbnailSize, mThumbnailSize, mThumbnailInset, mPathColor);