From a97c64bf9f57827eea8f680fff834b1140571a54 Mon Sep 17 00:00:00 2001 From: Hyunyoung Song Date: Thu, 30 Jun 2016 11:53:44 -0700 Subject: [PATCH] Fix hotseat flicker b/29648104 Change-Id: I74eea09ab5c4d03c0df3b4a82c7636299edf4d32 --- .../android/launcher3/BaseContainerView.java | 19 +++++++++++++------ .../WorkspaceStateTransitionAnimation.java | 3 ++- 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/src/com/android/launcher3/BaseContainerView.java b/src/com/android/launcher3/BaseContainerView.java index 45d0b5243b..f9c2407d46 100644 --- a/src/com/android/launcher3/BaseContainerView.java +++ b/src/com/android/launcher3/BaseContainerView.java @@ -18,6 +18,8 @@ package com.android.launcher3; import android.content.Context; import android.content.res.TypedArray; +import android.graphics.Color; +import android.graphics.drawable.ColorDrawable; import android.graphics.drawable.Drawable; import android.graphics.drawable.InsetDrawable; import android.util.AttributeSet; @@ -60,12 +62,17 @@ public abstract class BaseContainerView extends FrameLayout { mHorizontalPadding = DeviceProfile.getContainerPadding(context, width); } - TypedArray a = context.obtainStyledAttributes(attrs, - R.styleable.BaseContainerView, defStyleAttr, 0); - mRevealDrawable = new InsetDrawable( - a.getDrawable(R.styleable.BaseContainerView_revealBackground), - mHorizontalPadding, 0, mHorizontalPadding, 0); - a.recycle(); + if (FeatureFlags.LAUNCHER3_ALL_APPS_PULL_UP && this instanceof AllAppsContainerView) { + mRevealDrawable = new InsetDrawable(new ColorDrawable(Color.WHITE), mHorizontalPadding, + 0, mHorizontalPadding, 0); + } else { + TypedArray a = context.obtainStyledAttributes(attrs, + R.styleable.BaseContainerView, defStyleAttr, 0); + mRevealDrawable = new InsetDrawable( + a.getDrawable(R.styleable.BaseContainerView_revealBackground), + mHorizontalPadding, 0, mHorizontalPadding, 0); + a.recycle(); + } } @Override diff --git a/src/com/android/launcher3/WorkspaceStateTransitionAnimation.java b/src/com/android/launcher3/WorkspaceStateTransitionAnimation.java index ab4cd8da72..2fcd73d554 100644 --- a/src/com/android/launcher3/WorkspaceStateTransitionAnimation.java +++ b/src/com/android/launcher3/WorkspaceStateTransitionAnimation.java @@ -273,7 +273,8 @@ public class WorkspaceStateTransitionAnimation { // Update the workspace state float finalBackgroundAlpha = (states.stateIsSpringLoaded || states.stateIsOverview) ? 1.0f : 0f; - float finalHotseatAlpha = (states.stateIsNormal || states.stateIsSpringLoaded) ? 1f : 0f; + float finalHotseatAlpha = (states.stateIsNormal || states.stateIsSpringLoaded || + (FeatureFlags.LAUNCHER3_ALL_APPS_PULL_UP && states.stateIsNormalHidden)) ? 1f : 0f; float finalOverviewPanelAlpha = states.stateIsOverview ? 1f : 0f; float finalWorkspaceTranslationY = 0;