diff --git a/quickstep/res/layout/taskbar_all_apps_button.xml b/quickstep/res/layout/taskbar_all_apps_button.xml index 79d087a8ef..6b665e5623 100644 --- a/quickstep/res/layout/taskbar_all_apps_button.xml +++ b/quickstep/res/layout/taskbar_all_apps_button.xml @@ -13,10 +13,12 @@ See the License for the specific language governing permissions and limitations under the License. --> + + 76dp + 52dp diff --git a/quickstep/res/values/dimens.xml b/quickstep/res/values/dimens.xml index 403d6bd486..2eb4abc3fb 100644 --- a/quickstep/res/values/dimens.xml +++ b/quickstep/res/values/dimens.xml @@ -255,7 +255,10 @@ @*android:dimen/taskbar_frame_height 48dp - 48dp + 44dp + 48dp + + 12dp 54dp 16dp 16dp @@ -282,11 +285,11 @@ 72dp + 48dp 24dp 40dp 10dp 32dp - 10dp 16dp diff --git a/quickstep/src/com/android/launcher3/taskbar/TaskbarView.java b/quickstep/src/com/android/launcher3/taskbar/TaskbarView.java index 2433a3497a..2fcd64b5e6 100644 --- a/quickstep/src/com/android/launcher3/taskbar/TaskbarView.java +++ b/quickstep/src/com/android/launcher3/taskbar/TaskbarView.java @@ -101,16 +101,15 @@ public class TaskbarView extends FrameLayout implements FolderIcon.FolderIconPar super(context, attrs, defStyleAttr, defStyleRes); mActivityContext = ActivityContext.lookupContext(context); mIconLayoutBounds = mActivityContext.getTransientTaskbarBounds(); - mIsRtl = Utilities.isRtl(getResources()); - Resources resources = getResources(); - mIconTouchSize = resources.getDimensionPixelSize(R.dimen.taskbar_icon_touch_size); + mIsRtl = Utilities.isRtl(resources); - int actualMargin = DisplayController.isTransientTaskbar(mActivityContext) - ? resources.getDimensionPixelSize(R.dimen.transient_taskbar_icon_spacing) - : resources.getDimensionPixelSize(R.dimen.taskbar_icon_spacing); + int actualMargin = resources.getDimensionPixelSize(R.dimen.taskbar_icon_spacing); int actualIconSize = mActivityContext.getDeviceProfile().iconSizePx; + mIconTouchSize = Math.max(actualIconSize, + resources.getDimensionPixelSize(R.dimen.taskbar_icon_min_touch_size)); + // We layout the icons to be of mIconTouchSize in width and height mItemMarginLeftRight = actualMargin - (mIconTouchSize - actualIconSize) / 2; mItemPadding = (mIconTouchSize - actualIconSize) / 2; diff --git a/res/values-sw720dp/dimens.xml b/res/values-sw720dp/dimens.xml index 40e49f1545..09b2d6f83f 100644 --- a/res/values-sw720dp/dimens.xml +++ b/res/values-sw720dp/dimens.xml @@ -46,7 +46,4 @@ 24dp - - - 57dp diff --git a/res/values/dimens.xml b/res/values/dimens.xml index b57eb02292..4d2e1b7c6d 100644 --- a/res/values/dimens.xml +++ b/res/values/dimens.xml @@ -365,8 +365,8 @@ 18dp 50dp 0dp - 44dp - 50dp + 0dp + 0dp 0dp 0dp @@ -374,10 +374,7 @@ 0dp 0dp 0dp - - 0dp - - 8dp + 0dp 0dp 0dp 0dp diff --git a/src/com/android/launcher3/settings/SettingsActivity.java b/src/com/android/launcher3/settings/SettingsActivity.java index 3e2d051a0a..7ab3013da1 100644 --- a/src/com/android/launcher3/settings/SettingsActivity.java +++ b/src/com/android/launcher3/settings/SettingsActivity.java @@ -268,8 +268,8 @@ public class SettingsActivity extends FragmentActivity return !WidgetsModel.GO_DISABLE_NOTIFICATION_DOTS; case ALLOW_ROTATION_PREFERENCE_KEY: - DisplayController.Info info = InvariantDeviceProfile.INSTANCE.get( - getContext()).getDeviceProfile(getContext()).getDisplayInfo(); + DisplayController.Info info = + DisplayController.INSTANCE.get(getContext()).getInfo(); if (info.isTablet(info.realBounds)) { // Launcher supports rotation by default. No need to show this setting. return false; diff --git a/tests/src/com/android/launcher3/ui/WorkProfileTest.java b/tests/src/com/android/launcher3/ui/WorkProfileTest.java index 302bd2fd59..c7628ccd63 100644 --- a/tests/src/com/android/launcher3/ui/WorkProfileTest.java +++ b/tests/src/com/android/launcher3/ui/WorkProfileTest.java @@ -38,6 +38,7 @@ import com.android.launcher3.tapl.LauncherInstrumentation; import org.junit.After; import org.junit.Before; +import org.junit.Ignore; import org.junit.Test; import java.util.Objects; @@ -118,6 +119,7 @@ public class WorkProfileTest extends AbstractLauncherUiTest { } @Test + @Ignore("b/243855320") public void toggleWorks() { assumeTrue(mWorkProfileSetupSuccessful); waitForWorkTabSetup();