PawletOS/Lawnchair
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

Run the given callback only inside runOnPageScrollsInitialized

Browse Source 
Let `PagedView.runOnPageScrollsInitialized` run the given callback only
instead of running all the current existing callbacks inside
`mOnPageScrollsInitializedCallbacks` once `mPageScrolls` has been
initialized.
All the existing callbacks will be run by
`PagedView.onPageScrollsInitialized` instead.
By doing this, we can avoid some unexpected crash while running
the pending callbacks in some scenarios. E.g., removeAllViews.

Flag: EXEMPT fix a regression
Bug: 385612978
Test: Manual
Change-Id: I0877cff752aabd1569dd54a9d04001687f90a5f6
This commit is contained in:
minch
2025-01-08 18:38:31 +00:00
parent 569e032b24
commit a69673de08
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/com/android/launcher3/PagedView.java
+5 -3
View File
@@ -718,12 +718,14 @@ public abstract class PagedView<T extends View & PageIndicator> extends ViewGrou
}
/**
* Queues the given callback to be run once {@code mPageScrolls} has been initialized.
* Run the given `callback` immediately once {@code mPageScrolls} has been initialized,
* otherwise queue the callback to `mOnPageScrollsInitializedCallbacks`.
*/
public void runOnPageScrollsInitialized(Runnable callback) {
mOnPageScrollsInitializedCallbacks.add(callback);
if (isPageScrollsInitialized()) {
onPageScrollsInitialized();
callback.run();
} else {
mOnPageScrollsInitializedCallbacks.add(callback);
}
}