From e736b9c0c5b4eccd378f4b7214aa927c935660f8 Mon Sep 17 00:00:00 2001 From: Mady Mellor Date: Mon, 16 Sep 2024 16:58:08 -0700 Subject: [PATCH] Fix an issue where the bubble bar was visible after theme change Don't set the alpha to 1 in the drag reset method unless the bar is actually expanded. When theme changes, everything gets recreated... so the location of the bubble bar gets set which triggers drag reset which would make the bar visible when it shouldn't be. Flag: com.android.wm.shell.enable_bubble_bar Test: manual - have bubbles in app (stashed), change theme, observe that bubbles are not visible - test dragging bubbles from left to right via expanded view, individual bubble, and collapsed stack Bug: 358304168 (not exact bug but noted in the video of comment#13) Change-Id: I291cdb206532efe386684e36a78b9d66018f3cb1 --- .../com/android/launcher3/taskbar/bubbles/BubbleBarView.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/quickstep/src/com/android/launcher3/taskbar/bubbles/BubbleBarView.java b/quickstep/src/com/android/launcher3/taskbar/bubbles/BubbleBarView.java index c005640f51..b8f115d3be 100644 --- a/quickstep/src/com/android/launcher3/taskbar/bubbles/BubbleBarView.java +++ b/quickstep/src/com/android/launcher3/taskbar/bubbles/BubbleBarView.java @@ -689,7 +689,7 @@ public class BubbleBarView extends FrameLayout { } setAlphaDuringBubbleDrag(1f); setTranslationX(0f); - if (getBubbleChildCount() > 0) { + if (mIsBarExpanded && getBubbleChildCount() > 0) { setAlpha(1f); } }