From 1a8f6fb736c36548a44db6c7018771e3a895dda0 Mon Sep 17 00:00:00 2001 From: Sunny Goyal Date: Wed, 14 Jun 2017 15:35:16 -0700 Subject: [PATCH] Updating the fast scroll bar UI Bug: 37015359 Change-Id: Iec0748f04ebe9a3eef13ff759da3cab6ff28c3a1 --- .../container_fastscroll_popup_bg.xml | 27 ------ .../container_fastscroll_popup_bg.xml | 27 ------ res/layout/all_apps.xml | 6 +- res/layout/all_apps_discovery_item.xml | 4 +- .../all_apps_discovery_loading_divider.xml | 4 +- res/layout/all_apps_divider.xml | 4 +- res/layout/all_apps_search_divider.xml | 4 +- res/layout/all_apps_search_market.xml | 4 +- res/layout/widgets_view.xml | 2 +- res/values-land/dimens.xml | 15 +++- res/values-sw720dp/dimens.xml | 8 +- res/values/dimens.xml | 20 +++-- res/values/styles.xml | 8 +- .../android/launcher3/BaseRecyclerView.java | 7 -- .../BaseRecyclerViewFastScrollBar.java | 52 +++++------ .../allapps/AllAppsRecyclerView.java | 8 +- .../graphics/FastScrollThumbDrawable.java | 89 +++++++++++++++++++ .../launcher3/widget/WidgetsRecyclerView.java | 4 - 18 files changed, 161 insertions(+), 132 deletions(-) delete mode 100644 res/drawable-ldrtl/container_fastscroll_popup_bg.xml delete mode 100644 res/drawable/container_fastscroll_popup_bg.xml create mode 100644 src/com/android/launcher3/graphics/FastScrollThumbDrawable.java diff --git a/res/drawable-ldrtl/container_fastscroll_popup_bg.xml b/res/drawable-ldrtl/container_fastscroll_popup_bg.xml deleted file mode 100644 index 2bbf5cd72a..0000000000 --- a/res/drawable-ldrtl/container_fastscroll_popup_bg.xml +++ /dev/null @@ -1,27 +0,0 @@ - - - - - - - \ No newline at end of file diff --git a/res/drawable/container_fastscroll_popup_bg.xml b/res/drawable/container_fastscroll_popup_bg.xml deleted file mode 100644 index 3dc76800b0..0000000000 --- a/res/drawable/container_fastscroll_popup_bg.xml +++ /dev/null @@ -1,27 +0,0 @@ - - - - - - - \ No newline at end of file diff --git a/res/layout/all_apps.xml b/res/layout/all_apps.xml index 09b965544b..ff605f4bb8 100644 --- a/res/layout/all_apps.xml +++ b/res/layout/all_apps.xml @@ -54,8 +54,8 @@ android:overScrollMode="never" android:descendantFocusability="afterDescendants" android:focusable="true" - android:paddingStart="@dimen/container_fastscroll_thumb_max_width" - android:paddingEnd="@dimen/container_fastscroll_thumb_max_width" /> + android:paddingStart="@dimen/dynamic_grid_edge_margin" + android:paddingEnd="@dimen/dynamic_grid_edge_margin" /> + android:layout_marginEnd="@dimen/fastscroll_popup_margin" /> diff --git a/res/layout/all_apps_discovery_item.xml b/res/layout/all_apps_discovery_item.xml index fb1755c6b5..728283fc11 100644 --- a/res/layout/all_apps_discovery_item.xml +++ b/res/layout/all_apps_discovery_item.xml @@ -94,8 +94,8 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:layout_alignParentBottom="true" - android:paddingLeft="@dimen/container_fastscroll_thumb_max_width" - android:paddingRight="@dimen/container_fastscroll_thumb_max_width" + android:paddingLeft="@dimen/dynamic_grid_edge_margin" + android:paddingRight="@dimen/dynamic_grid_edge_margin" android:src="@drawable/all_apps_divider" android:scaleType="fitXY" android:focusable="false" /> diff --git a/res/layout/all_apps_discovery_loading_divider.xml b/res/layout/all_apps_discovery_loading_divider.xml index 1ad5521422..005847c541 100644 --- a/res/layout/all_apps_discovery_loading_divider.xml +++ b/res/layout/all_apps_discovery_loading_divider.xml @@ -16,8 +16,8 @@ + android:paddingLeft="@dimen/dynamic_grid_edge_margin" + android:paddingRight="@dimen/dynamic_grid_edge_margin"> \ No newline at end of file diff --git a/res/layout/all_apps_search_divider.xml b/res/layout/all_apps_search_divider.xml index d2ef691ead..c052c6635e 100644 --- a/res/layout/all_apps_search_divider.xml +++ b/res/layout/all_apps_search_divider.xml @@ -18,8 +18,8 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:paddingBottom="@dimen/all_apps_divider_margin_vertical" - android:paddingLeft="@dimen/container_fastscroll_thumb_max_width" - android:paddingRight="@dimen/container_fastscroll_thumb_max_width" + android:paddingLeft="@dimen/dynamic_grid_edge_margin" + android:paddingRight="@dimen/dynamic_grid_edge_margin" android:src="@drawable/all_apps_search_divider" android:scaleType="fitXY" android:focusable="false" /> \ No newline at end of file diff --git a/res/layout/all_apps_search_market.xml b/res/layout/all_apps_search_market.xml index 3f19b2515f..6f2dd3d21e 100644 --- a/res/layout/all_apps_search_market.xml +++ b/res/layout/all_apps_search_market.xml @@ -19,8 +19,8 @@ android:layout_width="match_parent" android:layout_height="48dp" android:gravity="center" - android:paddingLeft="@dimen/container_fastscroll_thumb_max_width" - android:paddingRight="@dimen/container_fastscroll_thumb_max_width" + android:paddingLeft="@dimen/dynamic_grid_edge_margin" + android:paddingRight="@dimen/dynamic_grid_edge_margin" android:fontFamily="sans-serif-medium" android:textSize="14sp" android:textColor="?android:attr/colorAccent" diff --git a/res/layout/widgets_view.xml b/res/layout/widgets_view.xml index 476901d1e6..47b068385d 100644 --- a/res/layout/widgets_view.xml +++ b/res/layout/widgets_view.xml @@ -53,7 +53,7 @@ style="@style/FastScrollerPopup" android:id="@+id/fast_scroller_popup" android:layout_gravity="top|end" - android:layout_marginEnd="@dimen/container_fastscroll_popup_margin" /> + android:layout_marginEnd="@dimen/fastscroll_popup_margin" /> - - 12% + + 12% + + + 58dp + 48dp + 10dp + 24dp + diff --git a/res/values-sw720dp/dimens.xml b/res/values-sw720dp/dimens.xml index 358d9b6a0c..e836d7d783 100644 --- a/res/values-sw720dp/dimens.xml +++ b/res/values-sw720dp/dimens.xml @@ -15,10 +15,16 @@ --> - + 8dp 54dp 64dp 180dp + + 75dp + 62dp + 13dp + 32dp + diff --git a/res/values/dimens.xml b/res/values/dimens.xml index 3a531b08db..57b4be4e2c 100644 --- a/res/values/dimens.xml +++ b/res/values/dimens.xml @@ -47,14 +47,18 @@ 13dp 24dp - - 5dp - 9dp - 18dp - 72dp - -24dp - 72dp - 48dp + + 6dp + 8dp + 1dp + 52dp + -24dp + + 75dp + 62dp + 13dp + 32dp + 19dp 0dp diff --git a/res/values/styles.xml b/res/values/styles.xml index 8af6968a61..594c7dbdea 100644 --- a/res/values/styles.xml +++ b/res/values/styles.xml @@ -86,11 +86,11 @@