Merge "Fix errorprone warnings" into main

src/com/android/launcher3/BubbleTextView.java

@@ -1106,7 +1106,7 @@ public class BubbleTextView extends TextView implements ItemInfoUpdateReceiver,
 
 
     public void applyDotState(ItemInfo itemInfo, boolean animate) {
-        if (mIcon instanceof FastBitmapDrawable) {
+        if (mIcon != null) {
             boolean wasDotted = mDotInfo != null;
             mDotInfo = mActivity.getDotInfoForItem(itemInfo);
             boolean isDotted = mDotInfo != null;

src/com/android/launcher3/Workspace.java

@@ -1750,7 +1750,7 @@ public class Workspace<T extends View & PageIndicator> extends PagedView<T>
         }
 
         final DragView dv;
-        if (contentView instanceof View) {
+        if (contentView != null) {
             dv = mDragController.startDrag(
                     contentView,
                     draggableView,

src/com/android/launcher3/search/StringMatcherUtility.java

@@ -127,17 +127,17 @@ public class StringMatcherUtility {
             if (query == null || target == null) {
                 return false;
             }
-            switch (mCollator.compare(query, target)) {
+            int compare = mCollator.compare(query, target);
-                case 0:
+            if (compare == 0) {
-                    return true;
+                return true;
-                case -1:
+            } else if (compare < 0) {
-                    // The target string can contain a modifier which would make it larger than
+                // The target string can contain a modifier which would make it larger than
-                    // the query string (even though the length is same). If the query becomes
+                // the query string (even though the length is same). If the query becomes
-                    // larger after appending a unicode character, it was originally a prefix of
+                // larger after appending a unicode character, it was originally a prefix of
-                    // the target string and hence should match.
+                // the target string and hence should match.
-                    return mCollator.compare(query + MAX_UNICODE, target) > -1;
+                return mCollator.compare(query + MAX_UNICODE, target) >= 0;
-                default:
+            } else {
-                    return false;
+                return false;
             }
         }