diff --git a/quickstep/src/com/android/launcher3/uioverrides/touchcontrollers/TwoButtonNavbarTouchController.java b/quickstep/src/com/android/launcher3/uioverrides/touchcontrollers/TwoButtonNavbarTouchController.java index b0d0b1528c..e2747dfcbb 100644 --- a/quickstep/src/com/android/launcher3/uioverrides/touchcontrollers/TwoButtonNavbarTouchController.java +++ b/quickstep/src/com/android/launcher3/uioverrides/touchcontrollers/TwoButtonNavbarTouchController.java @@ -78,18 +78,9 @@ public class TwoButtonNavbarTouchController extends AbstractStateChangeTouchCont return true; } if (AbstractFloatingView.getTopOpenView(mLauncher) != null) { - if (TestProtocol.sDebugTracing) { - Log.d(TestProtocol.TWO_BUTTON_NORMAL_NOT_OVERVIEW, - "Didn't intercept touch due to top view: " - + AbstractFloatingView.getTopOpenView(mLauncher)); - } return false; } if ((ev.getEdgeFlags() & EDGE_NAV_BAR) == 0) { - if (TestProtocol.sDebugTracing) { - Log.d(TestProtocol.TWO_BUTTON_NORMAL_NOT_OVERVIEW, - "Didn't intercept touch because event wasn't from nav bar"); - } return false; } if (!mIsTransposed && mLauncher.isInState(OVERVIEW)) { @@ -101,10 +92,6 @@ public class TwoButtonNavbarTouchController extends AbstractStateChangeTouchCont @Override public boolean onControllerInterceptTouchEvent(MotionEvent ev) { boolean intercept = super.onControllerInterceptTouchEvent(ev); - if (TestProtocol.sDebugTracing) { - Log.d(TestProtocol.TWO_BUTTON_NORMAL_NOT_OVERVIEW, - "2 button touch controller intercept touch? " + intercept); - } return intercept; } @@ -123,10 +110,6 @@ public class TwoButtonNavbarTouchController extends AbstractStateChangeTouchCont @Override protected void onReinitToState(LauncherState newToState) { super.onReinitToState(newToState); - - if (TestProtocol.sDebugTracing) { - Log.d(TestProtocol.TWO_BUTTON_NORMAL_NOT_OVERVIEW, "onReinitToState: " + newToState); - } } @Override @@ -175,9 +158,6 @@ public class TwoButtonNavbarTouchController extends AbstractStateChangeTouchCont @Override protected void onSwipeInteractionCompleted(LauncherState targetState) { super.onSwipeInteractionCompleted(targetState); - if (TestProtocol.sDebugTracing) { - Log.d(TestProtocol.TWO_BUTTON_NORMAL_NOT_OVERVIEW, "Reached state: " + targetState); - } if (!mIsTransposed) { mContinuousTouchCount++; } diff --git a/quickstep/src/com/android/quickstep/OrientationTouchTransformer.java b/quickstep/src/com/android/quickstep/OrientationTouchTransformer.java index 62b821c41d..35a851ab65 100644 --- a/quickstep/src/com/android/quickstep/OrientationTouchTransformer.java +++ b/quickstep/src/com/android/quickstep/OrientationTouchTransformer.java @@ -35,7 +35,6 @@ import android.view.Surface; import com.android.launcher3.R; import com.android.launcher3.ResourceUtils; -import com.android.launcher3.testing.TestProtocol; import com.android.launcher3.util.DisplayController.Info; import java.io.PrintWriter; @@ -92,7 +91,7 @@ class OrientationTouchTransformer { }; private static final String TAG = "OrientationTouchTransformer"; - private static final boolean DEBUG = true; + private static final boolean DEBUG = false; private static final int QUICKSTEP_ROTATION_UNINITIALIZED = -1; @@ -161,11 +160,9 @@ class OrientationTouchTransformer { resetSwipeRegions(info); } - void setNavigationMode(SysUINavigationMode.Mode newMode, Info info, - Resources newRes) { + void setNavigationMode(SysUINavigationMode.Mode newMode, Info info, Resources newRes) { if (DEBUG) { - Log.d(TestProtocol.NO_SWIPE_TO_HOME, "setNavigationMode new: " + newMode - + " oldMode: " + mMode + " " + this); + Log.d(TAG, "setNavigationMode new: " + newMode + " oldMode: " + mMode + " " + this); } if (mMode == newMode) { return; @@ -258,18 +255,10 @@ class OrientationTouchTransformer { mCurrentDisplay = new CurrentDisplay(region.currentSize, region.rotation); OrientationRectF regionToKeep = mSwipeTouchRegions.get(mCurrentDisplay); - if (DEBUG) { - Log.d(TestProtocol.NO_SWIPE_TO_HOME, "cached region: " + regionToKeep - + " mCurrentDisplay: " + mCurrentDisplay + " " + this); - } if (regionToKeep == null) { regionToKeep = createRegionForDisplay(region); } mSwipeTouchRegions.clear(); - if (DEBUG) { - Log.d(TestProtocol.NO_SWIPE_TO_HOME, "adding region: " + regionToKeep - + " mCurrentDisplay: " + mCurrentDisplay + " " + this); - } mSwipeTouchRegions.put(mCurrentDisplay, regionToKeep); updateAssistantRegions(regionToKeep); } @@ -301,10 +290,6 @@ class OrientationTouchTransformer { mAssistantLeftRegion.setEmpty(); mAssistantRightRegion.setEmpty(); int navbarSize = getNavbarSize(ResourceUtils.NAVBAR_LANDSCAPE_LEFT_RIGHT_SIZE); - if (DEBUG) { - Log.d(TestProtocol.NO_SWIPE_TO_HOME, "else case mode: " + mMode - + " getNavbarSize: " + navbarSize + " rotation: " + rotation + " " + this); - } switch (rotation) { case Surface.ROTATION_90: orientationRectF.left = orientationRectF.right @@ -355,8 +340,8 @@ class OrientationTouchTransformer { } boolean touchInValidSwipeRegions(float x, float y) { - if (TestProtocol.sDebugTracing) { - Log.d(TestProtocol.NO_SWIPE_TO_HOME, "touchInValidSwipeRegions " + x + "," + y + " in " + if (DEBUG) { + Log.d(TAG, "touchInValidSwipeRegions " + x + "," + y + " in " + mLastRectTouched + " this: " + this); } if (mLastRectTouched != null) { @@ -399,16 +384,10 @@ class OrientationTouchTransformer { } for (OrientationRectF rect : mSwipeTouchRegions.values()) { - if (TestProtocol.sDebugTracing) { - Log.d(TestProtocol.NO_SWIPE_TO_HOME, "transform:DOWN, rect=" + rect); - } if (rect == null) { continue; } if (rect.applyTransform(event, false)) { - if (TestProtocol.sDebugTracing) { - Log.d(TestProtocol.NO_SWIPE_TO_HOME, "setting mLastRectTouched"); - } mLastRectTouched = rect; mActiveTouchRotation = rect.mRotation; if (mEnableMultipleRegions diff --git a/quickstep/src/com/android/quickstep/RecentTasksList.java b/quickstep/src/com/android/quickstep/RecentTasksList.java index 2f1538bf5a..3302da0f77 100644 --- a/quickstep/src/com/android/quickstep/RecentTasksList.java +++ b/quickstep/src/com/android/quickstep/RecentTasksList.java @@ -93,10 +93,6 @@ public class RecentTasksList extends TaskStackChangeListener { * @return The change id of the current task list */ public synchronized int getTasks(boolean loadKeysOnly, Consumer> callback) { - if (TestProtocol.sDebugTracing) { - Log.d(TestProtocol.GET_RECENTS_FAILED, "getTasks: keysOnly=" + loadKeysOnly - + " callback=" + callback); - } final int requestLoadId = mChangeId; if (mResultsUi.isValidForRequest(requestLoadId, loadKeysOnly)) { // The list is up to date, send the callback on the next frame, @@ -105,9 +101,6 @@ public class RecentTasksList extends TaskStackChangeListener { // Copy synchronously as the changeId might change by next frame ArrayList result = copyOf(mResultsUi); mMainThreadExecutor.post(() -> { - if (TestProtocol.sDebugTracing) { - Log.d(TestProtocol.GET_RECENTS_FAILED, "getTasks: no new tasks"); - } callback.accept(result); }); } @@ -118,24 +111,15 @@ public class RecentTasksList extends TaskStackChangeListener { // Kick off task loading in the background mLoadingTasksInBackground = true; UI_HELPER_EXECUTOR.execute(() -> { - if (TestProtocol.sDebugTracing) { - Log.d(TestProtocol.GET_RECENTS_FAILED, "getTasks: loading in bg start"); - } if (!mResultsBg.isValidForRequest(requestLoadId, loadKeysOnly)) { mResultsBg = loadTasksInBackground(Integer.MAX_VALUE, requestLoadId, loadKeysOnly); } - if (TestProtocol.sDebugTracing) { - Log.d(TestProtocol.GET_RECENTS_FAILED, "getTasks: loading in bg end"); - } TaskLoadResult loadResult = mResultsBg; mMainThreadExecutor.execute(() -> { mLoadingTasksInBackground = false; mResultsUi = loadResult; if (callback != null) { ArrayList result = copyOf(mResultsUi); - if (TestProtocol.sDebugTracing) { - Log.d(TestProtocol.GET_RECENTS_FAILED, "getTasks: callback w/ bg results"); - } callback.accept(result); } }); diff --git a/quickstep/src/com/android/quickstep/RecentsAnimationDeviceState.java b/quickstep/src/com/android/quickstep/RecentsAnimationDeviceState.java index e271203d18..110b3563ac 100644 --- a/quickstep/src/com/android/quickstep/RecentsAnimationDeviceState.java +++ b/quickstep/src/com/android/quickstep/RecentsAnimationDeviceState.java @@ -229,7 +229,6 @@ public class RecentsAnimationDeviceState implements * Cleans up all the registered listeners and receivers. */ public void destroy() { - Log.d(TestProtocol.NO_SWIPE_TO_HOME, "destroying RADS", new Throwable()); for (Runnable r : mOnDestroyActions) { r.run(); } diff --git a/quickstep/src/com/android/quickstep/RotationTouchHelper.java b/quickstep/src/com/android/quickstep/RotationTouchHelper.java index 76298624d3..070d725890 100644 --- a/quickstep/src/com/android/quickstep/RotationTouchHelper.java +++ b/quickstep/src/com/android/quickstep/RotationTouchHelper.java @@ -133,8 +133,6 @@ public class RotationTouchHelper implements private RotationTouchHelper(Context context) { mContext = context; - Log.d(TestProtocol.NO_SWIPE_TO_HOME, "RotationTouchHelper ctor init? " + mNeedsInit - + " " + this); if (mNeedsInit) { init(); } @@ -142,11 +140,8 @@ public class RotationTouchHelper implements public void init() { if (!mNeedsInit) { - Log.d(TestProtocol.NO_SWIPE_TO_HOME, "Did not need init? " + " " + this); return; } - Log.d(TestProtocol.NO_SWIPE_TO_HOME, "RotationTouchHelper init() " + this, - new Throwable()); mDisplayController = DisplayController.INSTANCE.get(mContext); Resources resources = mContext.getResources(); mSysUiNavMode = SysUINavigationMode.INSTANCE.get(mContext); @@ -157,8 +152,6 @@ public class RotationTouchHelper implements // Register for navigation mode changes SysUINavigationMode.Mode newMode = mSysUiNavMode.addModeChangeListener(this); - Log.d(TestProtocol.NO_SWIPE_TO_HOME, "AddedModeChangeListener: " + this + - " currentMode: " + newMode); onNavigationModeChanged(newMode); runOnDestroy(() -> mSysUiNavMode.removeModeChangeListener(this)); @@ -204,7 +197,6 @@ public class RotationTouchHelper implements * Cleans up all the registered listeners and receivers. */ public void destroy() { - Log.d(TestProtocol.NO_SWIPE_TO_HOME, "destroying " + this); for (Runnable r : mOnDestroyActions) { r.run(); } @@ -253,7 +245,6 @@ public class RotationTouchHelper implements @Override public void onNavigationModeChanged(SysUINavigationMode.Mode newMode) { - Log.d(TestProtocol.NO_SWIPE_TO_HOME, "nav mode changed: " + newMode); mDisplayController.removeChangeListener(this); mDisplayController.addChangeListener(this); onDisplayInfoChanged(mContext, mDisplayController.getInfo(), CHANGE_ALL); diff --git a/quickstep/src/com/android/quickstep/TouchInteractionService.java b/quickstep/src/com/android/quickstep/TouchInteractionService.java index 5fe0fc72a2..027dd1cf8d 100644 --- a/quickstep/src/com/android/quickstep/TouchInteractionService.java +++ b/quickstep/src/com/android/quickstep/TouchInteractionService.java @@ -165,8 +165,6 @@ public class TouchInteractionService extends Service implements PluginListener tasks) { - if (TestProtocol.sDebugTracing) { - Log.d(TestProtocol.GET_RECENTS_FAILED, "applyLoadPlan: taskCount=" + tasks.size()); - for (Task t : tasks) { - Log.d(TestProtocol.GET_RECENTS_FAILED, "\t" + t); - } - } if (mPendingAnimation != null) { mPendingAnimation.addEndListener(success -> applyLoadPlan(tasks)); return; @@ -1127,11 +1121,6 @@ public abstract class RecentsView MAIN_EXECUTOR.submit(() -> { RecentsActivity activity = RecentsActivity.ACTIVITY_TRACKER.getCreatedActivity(); if (TestProtocol.sDebugTracing) { - Log.d(TestProtocol.GET_RECENTS_FAILED, "activity=" + activity); + Log.d(TestProtocol.FALLBACK_ACTIVITY_NO_SET, "activity=" + activity); } if (activity == null) { return false; @@ -212,10 +212,6 @@ public class FallbackRecentsTest { BaseOverview overview = mLauncher.getBackground().switchToOverview(); executeOnRecents(recents -> { - if (TestProtocol.sDebugTracing) { - Log.d(TestProtocol.GET_RECENTS_FAILED, "isLoading=" + - recents.getOverviewPanel().isLoadingTasks()); - } assertTrue("Don't have at least 3 tasks", getTaskCount(recents) >= 3); }); diff --git a/quickstep/tests/src/com/android/quickstep/TaplTestsQuickstep.java b/quickstep/tests/src/com/android/quickstep/TaplTestsQuickstep.java index a700e16d64..a5038a1fb0 100644 --- a/quickstep/tests/src/com/android/quickstep/TaplTestsQuickstep.java +++ b/quickstep/tests/src/com/android/quickstep/TaplTestsQuickstep.java @@ -189,12 +189,10 @@ public class TaplTestsQuickstep extends AbstractQuickStepTest { @NavigationModeSwitch @PortraitLandscape public void testSwitchToOverview() throws Exception { - Log.d(TestProtocol.LAUNCHER_NOT_TRANSPOSED, "testSwitchToOverview"); assertNotNull("Workspace.switchToOverview() returned null", mLauncher.pressHome().switchToOverview()); assertTrue("Launcher internal state didn't switch to Overview", isInState(() -> LauncherState.OVERVIEW)); - Log.d(TestProtocol.LAUNCHER_NOT_TRANSPOSED, "testSwitchToOverview finished"); } @Test diff --git a/src/com/android/launcher3/InvariantDeviceProfile.java b/src/com/android/launcher3/InvariantDeviceProfile.java index 7836fa384b..318dde1ecc 100644 --- a/src/com/android/launcher3/InvariantDeviceProfile.java +++ b/src/com/android/launcher3/InvariantDeviceProfile.java @@ -369,10 +369,6 @@ public class InvariantDeviceProfile { } private void onConfigChanged(Context context) { - if (TestProtocol.sDebugTracing) { - Log.d(TestProtocol.LAUNCHER_NOT_TRANSPOSED, "IDP.onConfigChanged"); - } - // Re-init grid String gridName = getCurrentGridName(context); initGrid(context, gridName); @@ -527,11 +523,6 @@ public class InvariantDeviceProfile { float availableWidth = config.screenWidthDp * res.getDisplayMetrics().density; float availableHeight = config.screenHeightDp * res.getDisplayMetrics().density; - if (TestProtocol.sDebugTracing) { - Log.d(TestProtocol.LAUNCHER_NOT_TRANSPOSED, - "getDeviceProfile: orientation=" + config.orientation - + " size=" + availableWidth + "x" + availableHeight); - } DeviceProfile bestMatch = supportedProfiles.get(0); float minDiff = Float.MAX_VALUE; diff --git a/src/com/android/launcher3/Launcher.java b/src/com/android/launcher3/Launcher.java index 5896f5a4de..92d1b11ded 100644 --- a/src/com/android/launcher3/Launcher.java +++ b/src/com/android/launcher3/Launcher.java @@ -554,21 +554,12 @@ public class Launcher extends StatefulActivity implements Launche onIdpChanged(mDeviceProfile.inv); } - if (TestProtocol.sDebugTracing) { - Log.d(TestProtocol.LAUNCHER_NOT_TRANSPOSED, "onConfigurationChanged: diff=" + diff); - Log.d(TestProtocol.LAUNCHER_NOT_TRANSPOSED, "newConfig=" + newConfig); - Log.d(TestProtocol.LAUNCHER_NOT_TRANSPOSED, "oldConfig=" + mOldConfig); - } - mOldConfig.setTo(newConfig); super.onConfigurationChanged(newConfig); } @Override public void onIdpChanged(InvariantDeviceProfile idp) { - if (TestProtocol.sDebugTracing) { - Log.d(TestProtocol.LAUNCHER_NOT_TRANSPOSED, "onIdpChanged"); - } initDeviceProfile(idp); dispatchDeviceProfileChanged(); reapplyUi(); diff --git a/src/com/android/launcher3/testing/TestProtocol.java b/src/com/android/launcher3/testing/TestProtocol.java index 3296ea51f6..4012e89a9a 100644 --- a/src/com/android/launcher3/testing/TestProtocol.java +++ b/src/com/android/launcher3/testing/TestProtocol.java @@ -109,10 +109,6 @@ public final class TestProtocol { public static final String REQUEST_MOCK_SENSOR_ROTATION = "mock-sensor-rotation"; public static final String PERMANENT_DIAG_TAG = "TaplTarget"; - public static final String LAUNCHER_NOT_TRANSPOSED = "b/185820525"; - public static final String NO_SWIPE_TO_HOME = "b/158017601"; public static final String WORK_PROFILE_REMOVED = "b/159671700"; - public static final String TIS_NO_EVENTS = "b/180915942"; - public static final String GET_RECENTS_FAILED = "b/177472267"; - public static final String TWO_BUTTON_NORMAL_NOT_OVERVIEW = "b/177316094"; + public static final String FALLBACK_ACTIVITY_NO_SET = "b/181019015"; } diff --git a/tests/src/com/android/launcher3/ui/PortraitLandscapeRunner.java b/tests/src/com/android/launcher3/ui/PortraitLandscapeRunner.java index 6c68daa8c1..8f2d5283ee 100644 --- a/tests/src/com/android/launcher3/ui/PortraitLandscapeRunner.java +++ b/tests/src/com/android/launcher3/ui/PortraitLandscapeRunner.java @@ -55,23 +55,19 @@ class PortraitLandscapeRunner implements TestRule { } private void evaluateInPortrait() throws Throwable { - Log.d(TestProtocol.LAUNCHER_NOT_TRANSPOSED, "evaluateInPortrait"); mTest.mDevice.setOrientationNatural(); mTest.mLauncher.setExpectedRotation(Surface.ROTATION_0); AbstractLauncherUiTest.checkDetectedLeaks(mTest.mLauncher); base.evaluate(); mTest.getDevice().pressHome(); - Log.d(TestProtocol.LAUNCHER_NOT_TRANSPOSED, "evaluateInPortrait finished"); } private void evaluateInLandscape() throws Throwable { - Log.d(TestProtocol.LAUNCHER_NOT_TRANSPOSED, "evaluateInLandscape"); mTest.mDevice.setOrientationLeft(); mTest.mLauncher.setExpectedRotation(Surface.ROTATION_90); AbstractLauncherUiTest.checkDetectedLeaks(mTest.mLauncher); base.evaluate(); mTest.getDevice().pressHome(); - Log.d(TestProtocol.LAUNCHER_NOT_TRANSPOSED, "evaluateInLandscape finished"); } }; }