From 7d8a0df1756e171bde3814b456c517f469dac7bc Mon Sep 17 00:00:00 2001 From: Schneider Victor-tulias Date: Wed, 5 Apr 2023 15:11:44 -0700 Subject: [PATCH] Clean up ENABLE_INPUT_CONSUMER_REASON_LOGGING flag: ENABLE_INPUT_CONSUMER_REASON_LOGGING Fixes: 270390028 Test: ran launcher and printed gesture nav logs Change-Id: I0fd0b82c1c812ddc43beba03bd456795f68ada55 --- .../com/android/quickstep/TouchInteractionService.java | 4 ---- src/com/android/launcher3/config/FeatureFlags.java | 8 ++------ 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/quickstep/src/com/android/quickstep/TouchInteractionService.java b/quickstep/src/com/android/quickstep/TouchInteractionService.java index 9102f2f444..b4990e4001 100644 --- a/quickstep/src/com/android/quickstep/TouchInteractionService.java +++ b/quickstep/src/com/android/quickstep/TouchInteractionService.java @@ -911,10 +911,6 @@ public class TouchInteractionService extends Service private void logInputConsumerSelectionReason( InputConsumer consumer, CompoundString reasonString) { - if (!FeatureFlags.ENABLE_INPUT_CONSUMER_REASON_LOGGING.get()) { - ActiveGestureLog.INSTANCE.addLog("setInputConsumer: " + consumer.getName()); - return; - } ActiveGestureLog.INSTANCE.addLog(new CompoundString("setInputConsumer: ") .append(consumer.getName()) .append(". reason(s):") diff --git a/src/com/android/launcher3/config/FeatureFlags.java b/src/com/android/launcher3/config/FeatureFlags.java index db4e6b95f8..4f5f14998f 100644 --- a/src/com/android/launcher3/config/FeatureFlags.java +++ b/src/com/android/launcher3/config/FeatureFlags.java @@ -69,17 +69,13 @@ public final class FeatureFlags { /** * Feature flag to handle define config changes dynamically instead of killing the process. - * + *

* * To add a new flag that can be toggled through the flags UI: - * + *

* Declare a new ToggleableFlag below. Give it a unique key (e.g. "QSB_ON_FIRST_SCREEN"), * and set a default value for the flag. This will be the default value on Debug builds. */ - public static final BooleanFlag ENABLE_INPUT_CONSUMER_REASON_LOGGING = getDebugFlag(270390028, - "ENABLE_INPUT_CONSUMER_REASON_LOGGING", ENABLED, - "Log the reason why an Input Consumer was selected for a gesture."); - public static final BooleanFlag ENABLE_GESTURE_ERROR_DETECTION = getDebugFlag(270389990, "ENABLE_GESTURE_ERROR_DETECTION", ENABLED, "Analyze gesture events and log detected errors");