From 609f2b31439cfedc49527645c228bf8c65a00cdf Mon Sep 17 00:00:00 2001 From: Mady Mellor Date: Thu, 13 Mar 2025 11:32:58 -0700 Subject: [PATCH] Update dragged elevation to use shared value (at 3dp) - Had to bump elevation of drop target so need to bumpe elevation of dragged views Flag: com.android.wm.shell.enable_bubble_anything Test: manual / visual - drag a bubble or drag expanded view and observe the drop targets Bug: 403276099 Change-Id: I15a1deb055c590b1f46261fcc307120fcb685c08 --- quickstep/res/values/dimens.xml | 3 ++- .../com/android/launcher3/taskbar/bubbles/BubbleBarView.java | 2 +- .../launcher3/taskbar/bubbles/BubbleBarViewController.java | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/quickstep/res/values/dimens.xml b/quickstep/res/values/dimens.xml index c74390ed58..bbf30b0738 100644 --- a/quickstep/res/values/dimens.xml +++ b/quickstep/res/values/dimens.xml @@ -459,7 +459,8 @@ 80dp 1dp - 2dp + + 3dp 90dp 20dp diff --git a/quickstep/src/com/android/launcher3/taskbar/bubbles/BubbleBarView.java b/quickstep/src/com/android/launcher3/taskbar/bubbles/BubbleBarView.java index d43ebe2977..1abef8a63f 100644 --- a/quickstep/src/com/android/launcher3/taskbar/bubbles/BubbleBarView.java +++ b/quickstep/src/com/android/launcher3/taskbar/bubbles/BubbleBarView.java @@ -204,7 +204,7 @@ public class BubbleBarView extends FrameLayout { mExpandedBarIconsSpacing = getResources().getDimensionPixelSize( R.dimen.bubblebar_expanded_icon_spacing); mBubbleElevation = getResources().getDimensionPixelSize(R.dimen.bubblebar_icon_elevation); - mDragElevation = getResources().getDimensionPixelSize(R.dimen.bubblebar_drag_elevation); + mDragElevation = getResources().getDimensionPixelSize(R.dimen.dragged_bubble_elevation); mPointerSize = getResources() .getDimensionPixelSize(R.dimen.bubblebar_pointer_visible_size); diff --git a/quickstep/src/com/android/launcher3/taskbar/bubbles/BubbleBarViewController.java b/quickstep/src/com/android/launcher3/taskbar/bubbles/BubbleBarViewController.java index 7fb6480005..9fb283cccf 100644 --- a/quickstep/src/com/android/launcher3/taskbar/bubbles/BubbleBarViewController.java +++ b/quickstep/src/com/android/launcher3/taskbar/bubbles/BubbleBarViewController.java @@ -222,7 +222,7 @@ public class BubbleBarViewController { mIconSize = res.getDimensionPixelSize(R.dimen.bubblebar_icon_size); mBubbleBarTaskbarMinDistance = res.getDimensionPixelSize( R.dimen.bubblebar_transient_taskbar_min_distance); - mDragElevation = res.getDimensionPixelSize(R.dimen.bubblebar_drag_elevation); + mDragElevation = res.getDimensionPixelSize(R.dimen.dragged_bubble_elevation); mTaskbarTranslationDelta = getBubbleBarTranslationDeltaForTaskbar(activity); if (DeviceConfig.isSmallTablet(mActivity)) { mBubbleBarDropTargetSize = res.getDimensionPixelSize(R.dimen.drag_zone_bubble_fold);