From 82638f6ef1270fa50bbf88ce7a4fd323193925c3 Mon Sep 17 00:00:00 2001 From: Winson Chung Date: Fri, 9 Sep 2022 05:30:04 +0000 Subject: [PATCH] Fix missing call to super cancel method - Without the call, it's interpreted as a successful animation to the listener even though it was canceled Bug: 245829938 Test: Swipe to previous task, immediately after settling touch the swipe area again Change-Id: I531cbda0c2bc8168a312a14854a7a73fafd8f678 --- src/com/android/launcher3/anim/AnimationSuccessListener.java | 3 +++ src/com/android/launcher3/statemanager/StateManager.java | 1 + 2 files changed, 4 insertions(+) diff --git a/src/com/android/launcher3/anim/AnimationSuccessListener.java b/src/com/android/launcher3/anim/AnimationSuccessListener.java index a312070e58..6196df23ed 100644 --- a/src/com/android/launcher3/anim/AnimationSuccessListener.java +++ b/src/com/android/launcher3/anim/AnimationSuccessListener.java @@ -19,6 +19,8 @@ package com.android.launcher3.anim; import android.animation.Animator; import android.animation.AnimatorListenerAdapter; +import androidx.annotation.CallSuper; + /** * Extension of {@link AnimatorListenerAdapter} for listening for non-cancelled animations */ @@ -27,6 +29,7 @@ public abstract class AnimationSuccessListener extends AnimatorListenerAdapter { protected boolean mCancelled = false; @Override + @CallSuper public void onAnimationCancel(Animator animation) { mCancelled = true; } diff --git a/src/com/android/launcher3/statemanager/StateManager.java b/src/com/android/launcher3/statemanager/StateManager.java index c44e1e1784..54e8e5bab8 100644 --- a/src/com/android/launcher3/statemanager/StateManager.java +++ b/src/com/android/launcher3/statemanager/StateManager.java @@ -345,6 +345,7 @@ public class StateManager> { @Override public void onAnimationCancel(Animator animation) { + super.onAnimationCancel(animation); onStateTransitionFailed(state); } };