diff --git a/quickstep/src/com/android/launcher3/taskbar/TaskbarUIController.java b/quickstep/src/com/android/launcher3/taskbar/TaskbarUIController.java index e5d642d9cb..89bcb41fc9 100644 --- a/quickstep/src/com/android/launcher3/taskbar/TaskbarUIController.java +++ b/quickstep/src/com/android/launcher3/taskbar/TaskbarUIController.java @@ -283,7 +283,7 @@ public class TaskbarUIController implements BubbleBarController.BubbleBarLocatio foundTask, taskContainer.getIconView().getDrawable(), taskContainer.getSnapshotView(), - taskContainer.getSplitAnimationThumbnail(), + taskContainer.getThumbnail(), null /* intent */, null /* user */, info); diff --git a/quickstep/src/com/android/quickstep/TaskShortcutFactory.java b/quickstep/src/com/android/quickstep/TaskShortcutFactory.java index 7990aaef5c..a69d472600 100644 --- a/quickstep/src/com/android/quickstep/TaskShortcutFactory.java +++ b/quickstep/src/com/android/quickstep/TaskShortcutFactory.java @@ -236,15 +236,14 @@ public interface TaskShortcutFactory { position[0] + width, position[1] + height); // Take the thumbnail of the task without a scrim and apply it back after - // TODO(b/348643341) add ability to get override the scrim for this Bitmap retrieval - float alpha = 0f; - if (!enableRefactorTaskThumbnail()) { - alpha = mTaskContainer.getThumbnailViewDeprecated().getDimAlpha(); + Bitmap thumbnail; + if (enableRefactorTaskThumbnail()) { + thumbnail = mTaskContainer.getThumbnail(); + } else { + float alpha = mTaskContainer.getThumbnailViewDeprecated().getDimAlpha(); mTaskContainer.getThumbnailViewDeprecated().setDimAlpha(0); - } - Bitmap thumbnail = RecentsTransition.drawViewIntoHardwareBitmap( - taskBounds.width(), taskBounds.height(), snapShotView, 1f, Color.BLACK); - if (!enableRefactorTaskThumbnail()) { + thumbnail = RecentsTransition.drawViewIntoHardwareBitmap( + taskBounds.width(), taskBounds.height(), snapShotView, 1f, Color.BLACK); mTaskContainer.getThumbnailViewDeprecated().setDimAlpha(alpha); } diff --git a/quickstep/src/com/android/quickstep/util/SplitAnimationController.kt b/quickstep/src/com/android/quickstep/util/SplitAnimationController.kt index 3c0a63af73..ac8b1d61b6 100644 --- a/quickstep/src/com/android/quickstep/util/SplitAnimationController.kt +++ b/quickstep/src/com/android/quickstep/util/SplitAnimationController.kt @@ -127,7 +127,7 @@ class SplitAnimationController(val splitSelectStateController: SplitSelectStateC val drawable = getDrawable(container.iconView, splitSelectSource) return SplitAnimInitProps( container.snapshotView, - container.splitAnimationThumbnail, + container.thumbnail, drawable, fadeWithThumbnail = true, isStagedTask = true, @@ -147,7 +147,7 @@ class SplitAnimationController(val splitSelectStateController: SplitSelectStateC val drawable = getDrawable(it.iconView, splitSelectSource) return SplitAnimInitProps( it.snapshotView, - it.splitAnimationThumbnail, + it.thumbnail, drawable, fadeWithThumbnail = true, isStagedTask = true, diff --git a/quickstep/src/com/android/quickstep/views/TaskContainer.kt b/quickstep/src/com/android/quickstep/views/TaskContainer.kt index bbe1af45ad..ef85aa1d90 100644 --- a/quickstep/src/com/android/quickstep/views/TaskContainer.kt +++ b/quickstep/src/com/android/quickstep/views/TaskContainer.kt @@ -75,7 +75,9 @@ class TaskContainer( } internal var thumbnailData: ThumbnailData? = null - val splitAnimationThumbnail: Bitmap? + + val thumbnail: Bitmap? + /** If possible don't use this. It should be replaced as part of b/331753115. */ get() = if (enableRefactorTaskThumbnail()) thumbnailData?.thumbnail else thumbnailViewDeprecated.thumbnail diff --git a/quickstep/src/com/android/quickstep/views/TaskView.kt b/quickstep/src/com/android/quickstep/views/TaskView.kt index 609262f770..f0cd76d35c 100644 --- a/quickstep/src/com/android/quickstep/views/TaskView.kt +++ b/quickstep/src/com/android/quickstep/views/TaskView.kt @@ -1396,7 +1396,7 @@ constructor( container.task, container.iconView.drawable, container.snapshotView, - container.splitAnimationThumbnail, + container.thumbnail, /* intent */ null, /* user */ null, container.itemInfo, diff --git a/quickstep/tests/multivalentTests/src/com/android/quickstep/util/SplitAnimationControllerTest.kt b/quickstep/tests/multivalentTests/src/com/android/quickstep/util/SplitAnimationControllerTest.kt index 505125132f..9d000a4687 100644 --- a/quickstep/tests/multivalentTests/src/com/android/quickstep/util/SplitAnimationControllerTest.kt +++ b/quickstep/tests/multivalentTests/src/com/android/quickstep/util/SplitAnimationControllerTest.kt @@ -89,7 +89,7 @@ class SplitAnimationControllerTest { @Before fun setup() { whenever(mockTaskContainer.snapshotView).thenReturn(mockSnapshotView) - whenever(mockTaskContainer.splitAnimationThumbnail).thenReturn(mockBitmap) + whenever(mockTaskContainer.thumbnail).thenReturn(mockBitmap) whenever(mockTaskContainer.iconView).thenReturn(mockIconView) whenever(mockTaskContainer.task).thenReturn(mockTask) whenever(mockIconView.drawable).thenReturn(mockTaskViewDrawable) @@ -117,7 +117,7 @@ class SplitAnimationControllerTest { assertEquals( "Did not fallback to use splitSource icon drawable", mockSplitSourceDrawable, - splitAnimInitProps.iconDrawable + splitAnimInitProps.iconDrawable, ) } @@ -133,7 +133,7 @@ class SplitAnimationControllerTest { assertEquals( "Did not use taskView icon drawable", mockTaskViewDrawable, - splitAnimInitProps.iconDrawable + splitAnimInitProps.iconDrawable, ) } @@ -152,7 +152,7 @@ class SplitAnimationControllerTest { assertEquals( "Did not use taskView icon drawable", mockTaskViewDrawable, - splitAnimInitProps.iconDrawable + splitAnimInitProps.iconDrawable, ) } @@ -168,7 +168,7 @@ class SplitAnimationControllerTest { assertEquals( "Did not use splitSource icon drawable", mockSplitSourceDrawable, - splitAnimInitProps.iconDrawable + splitAnimInitProps.iconDrawable, ) } @@ -190,13 +190,13 @@ class SplitAnimationControllerTest { val splitAnimInitProps: SplitAnimationController.Companion.SplitAnimInitProps = splitAnimationController.getFirstAnimInitViews( { mockGroupedTaskView }, - { splitSelectSource } + { splitSelectSource }, ) assertEquals( "Did not use splitSource icon drawable", mockSplitSourceDrawable, - splitAnimInitProps.iconDrawable + splitAnimInitProps.iconDrawable, ) } @@ -214,7 +214,7 @@ class SplitAnimationControllerTest { any(), any(), any(), - any() + any(), ) spySplitAnimationController.playSplitLaunchAnimation( @@ -230,7 +230,7 @@ class SplitAnimationControllerTest { null /* info */, null /* t */, {} /* finishCallback */, - 1f /* cornerRadius */ + 1f, /* cornerRadius */ ) verify(spySplitAnimationController) @@ -243,7 +243,7 @@ class SplitAnimationControllerTest { any(), any(), any(), - any() + any(), ) } @@ -267,7 +267,7 @@ class SplitAnimationControllerTest { transitionInfo, transaction, {} /* finishCallback */, - 1f /* cornerRadius */ + 1f, /* cornerRadius */ ) verify(spySplitAnimationController) @@ -296,7 +296,7 @@ class SplitAnimationControllerTest { transitionInfo, transaction, {} /* finishCallback */, - 1f /* cornerRadius */ + 1f, /* cornerRadius */ ) verify(spySplitAnimationController) @@ -325,7 +325,7 @@ class SplitAnimationControllerTest { transitionInfo, transaction, {} /* finishCallback */, - 1f /* cornerRadius */ + 1f, /* cornerRadius */ ) verify(spySplitAnimationController) @@ -353,7 +353,7 @@ class SplitAnimationControllerTest { transitionInfo, transaction, {} /* finishCallback */, - 1f /* cornerRadius */ + 1f, /* cornerRadius */ ) verify(spySplitAnimationController) @@ -381,7 +381,7 @@ class SplitAnimationControllerTest { transitionInfo, transaction, {} /* finishCallback */, - 1f /* cornerRadius */ + 1f, /* cornerRadius */ ) verify(spySplitAnimationController) @@ -408,7 +408,7 @@ class SplitAnimationControllerTest { transitionInfo, transaction, {} /* finishCallback */, - 1f /* cornerRadius */ + 1f, /* cornerRadius */ ) verify(spySplitAnimationController)