From b7b192bd7f24a2aa7d6881ee949657c9760c0305 Mon Sep 17 00:00:00 2001 From: Pinyao Ting Date: Tue, 12 Sep 2023 22:37:16 +0000 Subject: [PATCH 1/2] Fix permission bypass in legacy shortcut Intent created for Chooser should not be allowed in legacy shortcuts since it doesn't make sense for user to tap on a shortcut in homescreen to share, the expected share flow started from ShareSheet. Bug: 295334906, 295045199 Test: manual Change-Id: I8d0cbccdc31bd4cb927830e5ecf841147400fdfa Merged-In: I8d0cbccdc31bd4cb927830e5ecf841147400fdfa --- .../android/launcher3/util/PackageManagerHelper.java | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/src/com/android/launcher3/util/PackageManagerHelper.java b/src/com/android/launcher3/util/PackageManagerHelper.java index 02287fd0f1..fc6a91d1b8 100644 --- a/src/com/android/launcher3/util/PackageManagerHelper.java +++ b/src/com/android/launcher3/util/PackageManagerHelper.java @@ -155,15 +155,8 @@ public class PackageManagerHelper { public boolean hasPermissionForActivity(Intent intent, String srcPackage) { // b/270152142 if (Intent.ACTION_CHOOSER.equals(intent.getAction())) { - final Bundle extras = intent.getExtras(); - if (extras == null) { - return true; - } - // If given intent is ACTION_CHOOSER, verify srcPackage has permission over EXTRA_INTENT - intent = (Intent) extras.getParcelable(Intent.EXTRA_INTENT); - if (intent == null) { - return true; - } + // Chooser shortcuts is not a valid target + return false; } ResolveInfo target = mPm.resolveActivity(intent, 0); if (target == null) { From 5986dfe2d5085aab2e8aa715dbb3d2d3253dd136 Mon Sep 17 00:00:00 2001 From: Bill Yi Date: Wed, 27 Sep 2023 13:17:02 -0700 Subject: [PATCH 2/2] Import translations. DO NOT MERGE ANYWHERE Auto-generated-cl: translation import Change-Id: I6f49d0428e6d8fcb22ac648dbe81c039b1a80013 --- res/values-af/strings.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/res/values-af/strings.xml b/res/values-af/strings.xml index b5e4012296..aa963978aa 100644 --- a/res/values-af/strings.xml +++ b/res/values-af/strings.xml @@ -60,7 +60,7 @@ "Laai tans programme …" "Kon geen programme kry wat by \"%1$s\" pas nie" "Program" - "Alle programme" + "Alle apps" "Kennisgewings" "Raak en hou om \'n kortpad te skuif." "Dubbeltik en hou om \'n kortpad te skuif of gebruik gepasmaakte handelinge."