From b4e34d831f6fc32c72478ce68d2c0b1b7e07c272 Mon Sep 17 00:00:00 2001 From: Saumya Prakash Date: Tue, 4 Apr 2023 23:50:28 +0000 Subject: [PATCH] Add spacing to gesture nav edu for large fonts. For devices with smaller screens and the largest fonts and display sizes, the end screen of the gesture navigation tutorial would cut off the `Done` button at the bottom. This adds margins so that the button remains visible on the screen. Screenshot of Pixel 5 with the largest font and display: https://screenshot.googleplex.com/AU5rYYBisZ9Azbr.png Fix: 275540512 Test: Went through the tutorial with default and largest font sizes on both smaller devices and tablets to ensure the button is always visible. Change-Id: I66baf9b9044211550395bb3823797127de5e1f99 --- .../res/layout/redesigned_gesture_tutorial_fragment.xml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/quickstep/res/layout/redesigned_gesture_tutorial_fragment.xml b/quickstep/res/layout/redesigned_gesture_tutorial_fragment.xml index 43439c693e..28875184ab 100644 --- a/quickstep/res/layout/redesigned_gesture_tutorial_fragment.xml +++ b/quickstep/res/layout/redesigned_gesture_tutorial_fragment.xml @@ -205,15 +205,16 @@ android:id="@+id/checkmark_animation" android:layout_width="wrap_content" android:layout_height="wrap_content" + android:layout_marginBottom="44dp" android:gravity="center" android:scaleType="centerCrop" app:lottie_loop="false" android:visibility="gone" - app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" - app:layout_constraintTop_toBottomOf="@id/gesture_tutorial_fragment_feedback_subtitle" /> + app:layout_constraintTop_toBottomOf="@id/gesture_tutorial_fragment_feedback_subtitle" + app:layout_constraintBottom_toBottomOf="parent" />