From 8d8412f5b008d287df954392f819fe90090ea9d2 Mon Sep 17 00:00:00 2001 From: Schneider Victor-tulias Date: Wed, 13 Oct 2021 14:45:48 -0700 Subject: [PATCH] Update logging to help debug b/200572078 The class name logged in a repro of b/200572078 was insufficient after updated logs. Added more logging to get a pointer and stack trace when callbacks are added. Test: ran launcher and checked logs Bug: 200572078 Change-Id: I01bf98f488204311415a3946d66d99f656387cc4 --- src/com/android/launcher3/LauncherModel.java | 7 +++++++ src/com/android/launcher3/model/BaseLoaderResults.java | 4 +++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/com/android/launcher3/LauncherModel.java b/src/com/android/launcher3/LauncherModel.java index f38f66282a..ee6f51ed05 100644 --- a/src/com/android/launcher3/LauncherModel.java +++ b/src/com/android/launcher3/LauncherModel.java @@ -60,6 +60,7 @@ import com.android.launcher3.pm.InstallSessionTracker; import com.android.launcher3.pm.PackageInstallInfo; import com.android.launcher3.pm.UserCache; import com.android.launcher3.shortcuts.ShortcutRequest; +import com.android.launcher3.testing.TestProtocol; import com.android.launcher3.util.IntSet; import com.android.launcher3.util.ItemInfoMatcher; import com.android.launcher3.util.PackageUserKey; @@ -346,6 +347,12 @@ public class LauncherModel extends LauncherApps.Callback implements InstallSessi public void addCallbacks(Callbacks callbacks) { Preconditions.assertUIThread(); synchronized (mCallbacksList) { + if (TestProtocol.sDebugTracing) { + Log.d(TestProtocol.NULL_INT_SET, "addCallbacks pointer: " + + callbacks + + ", name: " + + callbacks.getClass().getName(), new Exception()); + } mCallbacksList.add(callbacks); } } diff --git a/src/com/android/launcher3/model/BaseLoaderResults.java b/src/com/android/launcher3/model/BaseLoaderResults.java index 3cae1e1e53..d270cc56a1 100644 --- a/src/com/android/launcher3/model/BaseLoaderResults.java +++ b/src/com/android/launcher3/model/BaseLoaderResults.java @@ -177,7 +177,9 @@ public abstract class BaseLoaderResults { if (TestProtocol.sDebugTracing) { Log.d(TestProtocol.NULL_INT_SET, "bind (1) currentScreenIds: " + currentScreenIds - + ", mCallBacks: " + + ", pointer: " + + mCallbacks + + ", name: " + mCallbacks.getClass().getName()); } filterCurrentWorkspaceItems(currentScreenIds, mWorkspaceItems, currentWorkspaceItems,