Cleanup split screen offset in TaskViewSimulator
- Removed mRunningTargetWindowPosition and mSplitOffset, as they countered each other out anyway - Removed PagedOrientationHandler#setLeashSplitOffset() since it's no longer used Test: Swipe up from split and non split apps in both orientations on large and small devices, with and without home rotation enabled Bug: 200817624 Change-Id: I78a80cbc718ee38a8933fa323798fb436710d59f
This commit is contained in:
@@ -19,7 +19,6 @@ package com.android.launcher3.touch;
|
||||
import android.content.res.Resources;
|
||||
import android.graphics.Canvas;
|
||||
import android.graphics.Matrix;
|
||||
import android.graphics.Point;
|
||||
import android.graphics.PointF;
|
||||
import android.graphics.Rect;
|
||||
import android.graphics.RectF;
|
||||
@@ -146,21 +145,6 @@ public interface PagedOrientationHandler {
|
||||
StagedSplitBounds splitInfo,
|
||||
@SplitConfigurationOptions.StagePosition int desiredStagePosition);
|
||||
|
||||
/**
|
||||
* It's important to note that {@link #setSplitTaskSwipeRect(DeviceProfile, Rect,
|
||||
* StagedSplitBounds, int)} above operates on the outRect based on
|
||||
* launcher's coordinate system, meaning it will treat the outRect as portrait if home rotation
|
||||
* is not allowed.
|
||||
*
|
||||
* However, here the splitOffset is from perspective of TaskViewSimulator, which is in display
|
||||
* orientation coordinates. So, for example, for the fake landscape scenario, even though
|
||||
* launcher is portrait, we inset the bottom/right task by an X coordinate instead of the
|
||||
* usual Y
|
||||
*/
|
||||
void setLeashSplitOffset(Point splitOffset, DeviceProfile dp,
|
||||
StagedSplitBounds splitInfo,
|
||||
@SplitConfigurationOptions.StagePosition int desiredStagePosition);
|
||||
|
||||
void measureGroupedTaskViewThumbnailBounds(View primarySnapshot, View secondarySnapshot,
|
||||
int parentWidth, int parentHeight,
|
||||
SplitConfigurationOptions.StagedSplitBounds splitBoundsConfig, DeviceProfile dp);
|
||||
|
||||
Reference in New Issue
Block a user