From 609e9642bc79d2d6d379f2a54ff317c5c717914d Mon Sep 17 00:00:00 2001 From: mpodolian Date: Fri, 20 Dec 2024 15:34:04 -0800 Subject: [PATCH] Fixes issue with missing overflow bubble The problem had two parts: 1 When BubbleBarViewController removed all views, including the overflow bubble, it did not update the value of the mOverflowAdded field 2 BubbleBarController removed all views upon receiving an initial update This CL addresses both issues. Test: Manual. Ensure the overflow bubble is present in the bubble bar. Rotate the device and verify that the overflow bubble remains visible. Flag: com.android.wm.shell.enable_bubble_bar Fixes: 380281090 Change-Id: I1810671e6bfc5b8b402433697b07f3de2e612ed7 --- .../android/launcher3/taskbar/bubbles/BubbleBarController.java | 1 + .../launcher3/taskbar/bubbles/BubbleBarViewController.java | 1 + 2 files changed, 2 insertions(+) diff --git a/quickstep/src/com/android/launcher3/taskbar/bubbles/BubbleBarController.java b/quickstep/src/com/android/launcher3/taskbar/bubbles/BubbleBarController.java index 5b3c233a8f..db9fa4f912 100644 --- a/quickstep/src/com/android/launcher3/taskbar/bubbles/BubbleBarController.java +++ b/quickstep/src/com/android/launcher3/taskbar/bubbles/BubbleBarController.java @@ -318,6 +318,7 @@ public class BubbleBarController extends IBubblesListener.Stub { // clear restored state mBubbleBarViewController.removeAllBubbles(); mBubbles.clear(); + mBubbleBarViewController.showOverflow(update.showOverflow); } BubbleBarBubble bubbleToSelect = null; diff --git a/quickstep/src/com/android/launcher3/taskbar/bubbles/BubbleBarViewController.java b/quickstep/src/com/android/launcher3/taskbar/bubbles/BubbleBarViewController.java index dd1b0ca87e..d34a22492a 100644 --- a/quickstep/src/com/android/launcher3/taskbar/bubbles/BubbleBarViewController.java +++ b/quickstep/src/com/android/launcher3/taskbar/bubbles/BubbleBarViewController.java @@ -1135,6 +1135,7 @@ public class BubbleBarViewController { /** Removes all existing bubble views */ public void removeAllBubbles() { + mOverflowAdded = false; mBarView.removeAllViews(); }