From 24521dd6f80b37f68ef59b50dda9927a23d91fe1 Mon Sep 17 00:00:00 2001 From: mpodolian Date: Wed, 27 Nov 2024 17:07:33 -0800 Subject: [PATCH] Only adjust the hotseat if bubble bar is visible. The change avoids setting up the hotseat if there is no bubble bar. Fixes: 379809704 Test: EXEMPT bugfix Flag: com.android.wm.shell.enable_bubble_bar Change-Id: I26820e3a13a4eaceb0897e44852c0d70aa71918b --- .../launcher3/taskbar/LauncherTaskbarUIController.java | 5 +++-- .../com/android/launcher3/taskbar/TaskbarControllers.java | 4 +++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/quickstep/src/com/android/launcher3/taskbar/LauncherTaskbarUIController.java b/quickstep/src/com/android/launcher3/taskbar/LauncherTaskbarUIController.java index c5be13dbe1..f0129b4501 100644 --- a/quickstep/src/com/android/launcher3/taskbar/LauncherTaskbarUIController.java +++ b/quickstep/src/com/android/launcher3/taskbar/LauncherTaskbarUIController.java @@ -18,8 +18,8 @@ package com.android.launcher3.taskbar; import static android.window.DesktopModeFlags.ENABLE_DESKTOP_WINDOWING_WALLPAPER_ACTIVITY; import static com.android.launcher3.QuickstepTransitionManager.TASKBAR_TO_APP_DURATION; -import static com.android.launcher3.QuickstepTransitionManager.getTaskbarToHomeDuration; import static com.android.launcher3.QuickstepTransitionManager.TRANSIENT_TASKBAR_TRANSITION_DURATION; +import static com.android.launcher3.QuickstepTransitionManager.getTaskbarToHomeDuration; import static com.android.launcher3.statemanager.BaseState.FLAG_NON_INTERACTIVE; import static com.android.launcher3.taskbar.TaskbarEduTooltipControllerKt.TOOLTIP_STEP_FEATURES; import static com.android.launcher3.taskbar.TaskbarLauncherStateController.FLAG_VISIBLE; @@ -275,7 +275,8 @@ public class LauncherTaskbarUIController extends TaskbarUIController { if (mControllers.bubbleControllers.isEmpty() || hotseat == null) return; boolean hiddenForBubbles = mControllers.bubbleControllers.get().bubbleBarViewController.isHiddenForNoBubbles(); - hotseat.post(() -> adjustHotseatForBubbleBar(!hiddenForBubbles)); + if (hiddenForBubbles) return; + hotseat.post(() -> adjustHotseatForBubbleBar(/* isBubbleBarVisible= */ true)); } /** diff --git a/quickstep/src/com/android/launcher3/taskbar/TaskbarControllers.java b/quickstep/src/com/android/launcher3/taskbar/TaskbarControllers.java index db707247ad..826722dbb3 100644 --- a/quickstep/src/com/android/launcher3/taskbar/TaskbarControllers.java +++ b/quickstep/src/com/android/launcher3/taskbar/TaskbarControllers.java @@ -227,7 +227,9 @@ public class TaskbarControllers { bubbleControllers.bubbleBarViewController.getBubbleBarLocation(); boolean hiddenForBubbles = bubbleControllers.bubbleBarViewController.isHiddenForNoBubbles(); - uiController.adjustHotseatForBubbleBar(!hiddenForBubbles); + if (!hiddenForBubbles) { + uiController.adjustHotseatForBubbleBar(/* isBubbleBarVisible= */ true); + } uiController.onBubbleBarLocationUpdated(location); }, () -> uiController.onBubbleBarLocationUpdated(null)); // Notify that the ui controller has changed