From 2003bc8dd829d805df6f231f7d5d2c85f815853b Mon Sep 17 00:00:00 2001 From: Tracy Zhou Date: Mon, 29 Jul 2024 10:13:48 -0700 Subject: [PATCH] Do not synchronizeNextDraw in phone mode Bug: 355973871 Test: Needs to verify with perfetto traces Flag: com.android.wm.shell.enable_taskbar_on_phones Change-Id: I84c258020951274915792d75d67c263135bbf2a9 --- .../launcher3/taskbar/TaskbarLauncherStateController.java | 7 +++---- .../launcher3/taskbar/VoiceInteractionWindowController.kt | 3 ++- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/quickstep/src/com/android/launcher3/taskbar/TaskbarLauncherStateController.java b/quickstep/src/com/android/launcher3/taskbar/TaskbarLauncherStateController.java index cb9f24ae80..20ab32ed2f 100644 --- a/quickstep/src/com/android/launcher3/taskbar/TaskbarLauncherStateController.java +++ b/quickstep/src/com/android/launcher3/taskbar/TaskbarLauncherStateController.java @@ -250,7 +250,7 @@ public class TaskbarLauncherStateController { applyState(0); - mCanSyncViews = true; + mCanSyncViews = !mControllers.taskbarActivityContext.isPhoneMode(); mLauncher.addOnDeviceProfileChangeListener(mOnDeviceProfileChangeListener); updateOverviewDragState(mLauncherState); } @@ -263,7 +263,7 @@ public class TaskbarLauncherStateController { mLauncher.getHotseat().setIconsAlpha(1f); mLauncher.getStateManager().removeStateListener(mStateListener); - mCanSyncViews = true; + mCanSyncViews = !mControllers.taskbarActivityContext.isPhoneMode(); mLauncher.removeOnDeviceProfileChangeListener(mOnDeviceProfileChangeListener); } @@ -743,8 +743,7 @@ public class TaskbarLauncherStateController { if (firstFrameVisChanged && mCanSyncViews && !Utilities.isRunningInTestHarness()) { ViewRootSync.synchronizeNextDraw(mLauncher.getHotseat(), mControllers.taskbarActivityContext.getDragLayer(), - () -> { - }); + () -> {}); } } diff --git a/quickstep/src/com/android/launcher3/taskbar/VoiceInteractionWindowController.kt b/quickstep/src/com/android/launcher3/taskbar/VoiceInteractionWindowController.kt index 5a5ff8e880..619c9c4f6a 100644 --- a/quickstep/src/com/android/launcher3/taskbar/VoiceInteractionWindowController.kt +++ b/quickstep/src/com/android/launcher3/taskbar/VoiceInteractionWindowController.kt @@ -41,7 +41,8 @@ private const val TEMP_BACKGROUND_WINDOW_TITLE = "VoiceInteractionTaskbarBackgro class VoiceInteractionWindowController(val context: TaskbarActivityContext) : TaskbarControllers.LoggableTaskbarController, TaskbarControllers.BackgroundRendererController { - private val isSeparateBackgroundEnabled = !DisplayController.isTransientTaskbar(context) + private val isSeparateBackgroundEnabled = + !DisplayController.isTransientTaskbar(context) && !context.isPhoneMode private val taskbarBackgroundRenderer = TaskbarBackgroundRenderer(context) private val nonTouchableInsetsComputer = ViewTreeObserver.OnComputeInternalInsetsListener {