From 38c59cfe4ab5689b88c7ac7e0d5cd4a3e4f8e0af Mon Sep 17 00:00:00 2001 From: Schneider Victor-tulias Date: Thu, 3 Feb 2022 16:07:04 -0800 Subject: [PATCH] Update gesture nav tutorial with updated phone landscape layouts - Updated layout files to support landscape mode on phones - Updated All Set page to say "tablet" rather than "phone" on tablets - Hiding feedback view during gestures for better visibility - Renamed files and resources to say "tablet" rather than "foldable" - Added custom layout logic for the mock hotseat on foldables - Updated feedback view margins Test: manual Fixes: 215063763 Fixes: 206895841 Fixes: 219251891 Change-Id: I56f7f33dd0617bdeeca4863f7d5de0143376c8bf --- .../res/drawable/bg_sandbox_feedback.xml | 3 +- .../gesture_tutorial_mock_hotseat.xml | 80 +++ .../gesture_tutorial_tablet_mock_hotseat.xml | 123 ++++ quickstep/res/layout/activity_allset.xml | 7 +- ...gesture_tutorial_foldable_mock_hotseat.xml | 18 +- .../res/layout/gesture_tutorial_fragment.xml | 41 +- .../gesture_tutorial_mock_conversation.xml | 16 +- ...esture_tutorial_mock_conversation_list.xml | 557 +++++++++--------- .../layout/gesture_tutorial_mock_webpage.xml | 24 +- ...ure_tutorial_tablet_mock_conversation.xml} | 24 +- ...utorial_tablet_mock_conversation_list.xml} | 34 +- .../gesture_tutorial_tablet_mock_hotseat.xml | 122 ++++ ... gesture_tutorial_tablet_mock_taskbar.xml} | 0 ... gesture_tutorial_tablet_mock_webpage.xml} | 0 quickstep/res/values-land/dimens.xml | 57 ++ quickstep/res/values/dimens.xml | 50 +- quickstep/res/values/strings.xml | 4 +- quickstep/res/values/styles.xml | 15 +- .../quickstep/interaction/AllSetActivity.java | 7 + .../BackGestureTutorialController.java | 4 +- .../HomeGestureTutorialController.java | 2 +- .../OverviewGestureTutorialController.java | 2 +- .../SwipeUpGestureTutorialController.java | 9 + .../interaction/TutorialController.java | 61 +- .../interaction/TutorialFragment.java | 29 +- .../interaction/TutorialStepIndicator.java | 10 +- .../quickstep/util/RecentsOrientedState.java | 9 +- 27 files changed, 910 insertions(+), 398 deletions(-) create mode 100644 quickstep/res/layout-land/gesture_tutorial_mock_hotseat.xml create mode 100644 quickstep/res/layout-land/gesture_tutorial_tablet_mock_hotseat.xml rename quickstep/res/layout/{gesture_tutorial_foldable_mock_conversation.xml => gesture_tutorial_tablet_mock_conversation.xml} (93%) rename quickstep/res/layout/{gesture_tutorial_foldable_mock_conversation_list.xml => gesture_tutorial_tablet_mock_conversation_list.xml} (95%) create mode 100644 quickstep/res/layout/gesture_tutorial_tablet_mock_hotseat.xml rename quickstep/res/layout/{gesture_tutorial_foldable_mock_taskbar.xml => gesture_tutorial_tablet_mock_taskbar.xml} (100%) rename quickstep/res/layout/{gesture_tutorial_foldable_mock_webpage.xml => gesture_tutorial_tablet_mock_webpage.xml} (100%) diff --git a/quickstep/res/drawable/bg_sandbox_feedback.xml b/quickstep/res/drawable/bg_sandbox_feedback.xml index 83a3deada8..83d7e4396c 100644 --- a/quickstep/res/drawable/bg_sandbox_feedback.xml +++ b/quickstep/res/drawable/bg_sandbox_feedback.xml @@ -14,7 +14,8 @@ limitations under the License. --> - + diff --git a/quickstep/res/layout-land/gesture_tutorial_mock_hotseat.xml b/quickstep/res/layout-land/gesture_tutorial_mock_hotseat.xml new file mode 100644 index 0000000000..20d2ecc59f --- /dev/null +++ b/quickstep/res/layout-land/gesture_tutorial_mock_hotseat.xml @@ -0,0 +1,80 @@ + + + + + + + + + + + + + \ No newline at end of file diff --git a/quickstep/res/layout-land/gesture_tutorial_tablet_mock_hotseat.xml b/quickstep/res/layout-land/gesture_tutorial_tablet_mock_hotseat.xml new file mode 100644 index 0000000000..6877b89716 --- /dev/null +++ b/quickstep/res/layout-land/gesture_tutorial_tablet_mock_hotseat.xml @@ -0,0 +1,123 @@ + + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/quickstep/res/layout/activity_allset.xml b/quickstep/res/layout/activity_allset.xml index 9ad10dc54e..06dfa37263 100644 --- a/quickstep/res/layout/activity_allset.xml +++ b/quickstep/res/layout/activity_allset.xml @@ -60,7 +60,7 @@ + android:gravity="start"/> + + android:paddingStart="@dimen/gesture_tutorial_hotseat_padding_start_end" + android:paddingEnd="@dimen/gesture_tutorial_hotseat_padding_start_end"> + android:layout_width="@dimen/gesture_tutorial_hotseat_width" + android:layout_height="@dimen/gesture_tutorial_hotseat_height"/> @@ -102,7 +100,7 @@ android:background="@drawable/gesture_tutorial_ripple"/> - - + + \ No newline at end of file diff --git a/quickstep/res/layout/gesture_tutorial_mock_conversation.xml b/quickstep/res/layout/gesture_tutorial_mock_conversation.xml index e8d5d79a58..5550389e25 100644 --- a/quickstep/res/layout/gesture_tutorial_mock_conversation.xml +++ b/quickstep/res/layout/gesture_tutorial_mock_conversation.xml @@ -34,8 +34,8 @@ android:layout_height="0dp" android:layout_marginTop="43dp" android:layout_marginBottom="22dp" - android:layout_marginStart="34dp" - android:layout_marginEnd="211dp" + android:layout_marginStart="@dimen/gesture_tutorial_top_bar_margin_start" + android:layout_marginEnd="@dimen/gesture_tutorial_top_bar_margin_end" app:cardElevation="0dp" app:cardCornerRadius="4dp" @@ -84,7 +84,7 @@ android:layout_width="match_parent" android:layout_height="0dp" android:background="@color/mock_conversation_background" - android:paddingBottom="66dp" + android:paddingBottom="@dimen/gesture_tutorial_conversation_bottom_padding" app:layout_constraintTop_toBottomOf="@id/top_bar" app:layout_constraintBottom_toBottomOf="parent" @@ -108,6 +108,7 @@ android:layout_marginBottom="@dimen/gesture_tutorial_message_large_margin_bottom" android:layout_marginStart="124dp" android:layout_marginEnd="@dimen/gesture_tutorial_message_padding_end" + android:visibility="@integer/gesture_tutorial_extra_messages_visibility" app:cardElevation="0dp" app:cardCornerRadius="18dp" @@ -122,6 +123,7 @@ android:layout_height="@dimen/gesture_tutorial_message_icon_size" android:layout_marginBottom="@dimen/gesture_tutorial_message_large_margin_bottom" android:layout_marginStart="@dimen/gesture_tutorial_message_padding_start" + android:visibility="@integer/gesture_tutorial_extra_messages_visibility" app:cardElevation="0dp" app:cardCornerRadius="@dimen/gesture_tutorial_message_icon_corner_radius" @@ -135,6 +137,7 @@ android:layout_height="36dp" android:layout_marginStart="17dp" android:layout_marginEnd="112dp" + android:visibility="@integer/gesture_tutorial_extra_messages_visibility" app:cardElevation="0dp" app:cardCornerRadius="18dp" @@ -151,6 +154,7 @@ android:layout_marginBottom="@dimen/gesture_tutorial_message_small_margin_bottom" android:layout_marginStart="280dp" android:layout_marginEnd="@dimen/gesture_tutorial_message_padding_end" + android:visibility="@integer/gesture_tutorial_extra_messages_visibility" app:cardElevation="0dp" app:cardCornerRadius="18dp" @@ -164,7 +168,7 @@ android:layout_width="0dp" android:layout_height="74dp" android:layout_marginBottom="@dimen/gesture_tutorial_message_large_margin_bottom" - android:layout_marginStart="124dp" + android:layout_marginStart="@dimen/gesture_tutorial_message_margin_start" android:layout_marginEnd="@dimen/gesture_tutorial_message_padding_end" app:cardElevation="0dp" @@ -192,7 +196,7 @@ android:layout_width="0dp" android:layout_height="36dp" android:layout_marginStart="17dp" - android:layout_marginEnd="144dp" + android:layout_marginEnd="@dimen/gesture_tutorial_reply_margin_end" app:cardElevation="0dp" app:cardCornerRadius="18dp" @@ -206,7 +210,7 @@ android:id="@+id/message_4" android:layout_width="0dp" android:layout_height="74dp" - android:layout_marginStart="124dp" + android:layout_marginStart="@dimen/gesture_tutorial_message_margin_start" android:layout_marginEnd="@dimen/gesture_tutorial_message_padding_end" app:cardElevation="0dp" diff --git a/quickstep/res/layout/gesture_tutorial_mock_conversation_list.xml b/quickstep/res/layout/gesture_tutorial_mock_conversation_list.xml index 364ad6d17d..a172ad3712 100644 --- a/quickstep/res/layout/gesture_tutorial_mock_conversation_list.xml +++ b/quickstep/res/layout/gesture_tutorial_mock_conversation_list.xml @@ -35,7 +35,7 @@ android:layout_marginTop="43dp" android:layout_marginBottom="22dp" android:layout_marginStart="34dp" - android:layout_marginEnd="35dp" + android:layout_marginEnd="34dp" app:cardElevation="0dp" app:cardCornerRadius="4dp" @@ -51,337 +51,336 @@ android:layout_width="match_parent" android:layout_height="0dp" android:background="@color/mock_list_background" - android:paddingBottom="66dp" + android:paddingTop="@dimen/gesture_tutorial_conversation_list_padding_top" + android:paddingStart="26dp" app:layout_constraintTop_toBottomOf="@id/top_bar" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintStart_toStartOf="parent" app:layout_constraintEnd_toEndOf="parent"> - + app:layout_constraintStart_toStartOf="parent"/> - + app:cardElevation="0dp" + app:cardCornerRadius="4dp" + app:cardBackgroundColor="@color/mock_list_preview_message" + app:layout_constraintVertical_chainStyle="packed" + app:layout_constraintTop_toTopOf="@id/conversation_icon_1" + app:layout_constraintStart_toEndOf="@id/conversation_icon_1" + app:layout_constraintEnd_toEndOf="parent" + app:layout_constraintBottom_toTopOf="@id/conversation_line_2"/> - + app:cardElevation="0dp" + app:cardCornerRadius="4dp" + app:cardBackgroundColor="@color/mock_list_preview_message" + app:layout_constraintTop_toBottomOf="@id/conversation_line_1" + app:layout_constraintStart_toEndOf="@id/conversation_icon_1" + app:layout_constraintEnd_toEndOf="parent" + app:layout_constraintBottom_toBottomOf="@id/conversation_icon_1"/> - + app:cardElevation="0dp" + app:cardCornerRadius="@dimen/gesture_tutorial_conversation_icon_corner_radius" + app:cardBackgroundColor="@color/mock_list_profile_icon" + app:layout_constraintTop_toBottomOf="@id/conversation_icon_1" + app:layout_constraintStart_toStartOf="parent"/> - + app:cardElevation="0dp" + app:cardCornerRadius="4dp" + app:cardBackgroundColor="@color/mock_list_preview_message" + app:layout_constraintVertical_chainStyle="packed" + app:layout_constraintTop_toTopOf="@id/conversation_icon_2" + app:layout_constraintStart_toEndOf="@id/conversation_icon_2" + app:layout_constraintEnd_toEndOf="parent" + app:layout_constraintBottom_toTopOf="@id/conversation_line_4"/> - + app:cardElevation="0dp" + app:cardCornerRadius="4dp" + app:cardBackgroundColor="@color/mock_list_preview_message" + app:layout_constraintTop_toBottomOf="@id/conversation_line_3" + app:layout_constraintStart_toEndOf="@id/conversation_icon_2" + app:layout_constraintEnd_toEndOf="parent" + app:layout_constraintBottom_toBottomOf="@id/conversation_icon_2"/> - + app:cardElevation="0dp" + app:cardCornerRadius="@dimen/gesture_tutorial_conversation_icon_corner_radius" + app:cardBackgroundColor="@color/mock_list_profile_icon" + app:layout_constraintTop_toBottomOf="@id/conversation_icon_2" + app:layout_constraintStart_toStartOf="parent"/> - + app:cardElevation="0dp" + app:cardCornerRadius="4dp" + app:cardBackgroundColor="@color/mock_list_preview_message" + app:layout_constraintVertical_chainStyle="packed" + app:layout_constraintTop_toTopOf="@id/conversation_icon_3" + app:layout_constraintStart_toEndOf="@id/conversation_icon_3" + app:layout_constraintEnd_toEndOf="parent" + app:layout_constraintBottom_toTopOf="@id/conversation_line_6"/> - + app:cardElevation="0dp" + app:cardCornerRadius="4dp" + app:cardBackgroundColor="@color/mock_list_preview_message" + app:layout_constraintTop_toBottomOf="@id/conversation_line_5" + app:layout_constraintStart_toEndOf="@id/conversation_icon_3" + app:layout_constraintEnd_toEndOf="parent" + app:layout_constraintBottom_toBottomOf="@id/conversation_icon_3"/> - + app:cardElevation="0dp" + app:cardCornerRadius="@dimen/gesture_tutorial_conversation_icon_corner_radius" + app:cardBackgroundColor="@color/mock_list_profile_icon" + app:layout_constraintTop_toBottomOf="@id/conversation_icon_3" + app:layout_constraintStart_toStartOf="parent"/> - + app:cardElevation="0dp" + app:cardCornerRadius="4dp" + app:cardBackgroundColor="@color/mock_list_preview_message" + app:layout_constraintVertical_chainStyle="packed" + app:layout_constraintTop_toTopOf="@id/conversation_icon_4" + app:layout_constraintStart_toEndOf="@id/conversation_icon_4" + app:layout_constraintEnd_toEndOf="parent" + app:layout_constraintBottom_toTopOf="@id/conversation_line_8"/> - + app:cardElevation="0dp" + app:cardCornerRadius="4dp" + app:cardBackgroundColor="@color/mock_list_preview_message" + app:layout_constraintTop_toBottomOf="@id/conversation_line_7" + app:layout_constraintStart_toEndOf="@id/conversation_icon_4" + app:layout_constraintEnd_toEndOf="parent" + app:layout_constraintBottom_toBottomOf="@id/conversation_icon_4"/> - + app:cardElevation="0dp" + app:cardCornerRadius="@dimen/gesture_tutorial_conversation_icon_corner_radius" + app:cardBackgroundColor="@color/mock_list_profile_icon" + app:layout_constraintTop_toBottomOf="@id/conversation_icon_4" + app:layout_constraintStart_toStartOf="parent"/> - + app:cardElevation="0dp" + app:cardCornerRadius="4dp" + app:cardBackgroundColor="@color/mock_list_preview_message" + app:layout_constraintVertical_chainStyle="packed" + app:layout_constraintTop_toTopOf="@id/conversation_icon_5" + app:layout_constraintStart_toEndOf="@id/conversation_icon_5" + app:layout_constraintEnd_toEndOf="parent" + app:layout_constraintBottom_toTopOf="@id/conversation_line_10"/> - + app:cardElevation="0dp" + app:cardCornerRadius="4dp" + app:cardBackgroundColor="@color/mock_list_preview_message" + app:layout_constraintTop_toBottomOf="@id/conversation_line_9" + app:layout_constraintStart_toEndOf="@id/conversation_icon_5" + app:layout_constraintEnd_toEndOf="parent" + app:layout_constraintBottom_toBottomOf="@id/conversation_icon_5"/> - + app:cardElevation="0dp" + app:cardCornerRadius="@dimen/gesture_tutorial_conversation_icon_corner_radius" + app:cardBackgroundColor="@color/mock_list_profile_icon" + app:layout_constraintTop_toBottomOf="@id/conversation_icon_5" + app:layout_constraintStart_toStartOf="parent"/> - + app:cardElevation="0dp" + app:cardCornerRadius="4dp" + app:cardBackgroundColor="@color/mock_list_preview_message" + app:layout_constraintVertical_chainStyle="packed" + app:layout_constraintTop_toTopOf="@id/conversation_icon_6" + app:layout_constraintStart_toEndOf="@id/conversation_icon_6" + app:layout_constraintEnd_toEndOf="parent" + app:layout_constraintBottom_toTopOf="@id/conversation_line_12"/> - + app:cardElevation="0dp" + app:cardCornerRadius="4dp" + app:cardBackgroundColor="@color/mock_list_preview_message" + app:layout_constraintTop_toBottomOf="@id/conversation_line_11" + app:layout_constraintStart_toEndOf="@id/conversation_icon_6" + app:layout_constraintEnd_toEndOf="parent" + app:layout_constraintBottom_toBottomOf="@id/conversation_icon_6"/> - + app:cardElevation="0dp" + app:cardCornerRadius="@dimen/gesture_tutorial_conversation_icon_corner_radius" + app:cardBackgroundColor="@color/mock_list_profile_icon" + app:layout_constraintTop_toBottomOf="@id/conversation_icon_6" + app:layout_constraintStart_toStartOf="parent"/> - + app:cardElevation="0dp" + app:cardCornerRadius="4dp" + app:cardBackgroundColor="@color/mock_list_preview_message" + app:layout_constraintVertical_chainStyle="packed" + app:layout_constraintTop_toTopOf="@id/conversation_icon_7" + app:layout_constraintStart_toEndOf="@id/conversation_icon_7" + app:layout_constraintEnd_toEndOf="parent" + app:layout_constraintBottom_toTopOf="@id/conversation_line_14"/> - - - - - + app:cardElevation="0dp" + app:cardCornerRadius="4dp" + app:cardBackgroundColor="@color/mock_list_preview_message" + app:layout_constraintTop_toBottomOf="@id/conversation_line_13" + app:layout_constraintStart_toEndOf="@id/conversation_icon_7" + app:layout_constraintEnd_toEndOf="parent" + app:layout_constraintBottom_toBottomOf="@id/conversation_icon_7"/> + app:layout_constraintEnd_toEndOf="parent"> + + - - \ No newline at end of file diff --git a/quickstep/res/layout/gesture_tutorial_tablet_mock_hotseat.xml b/quickstep/res/layout/gesture_tutorial_tablet_mock_hotseat.xml new file mode 100644 index 0000000000..027e4a05b0 --- /dev/null +++ b/quickstep/res/layout/gesture_tutorial_tablet_mock_hotseat.xml @@ -0,0 +1,122 @@ + + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/quickstep/res/layout/gesture_tutorial_foldable_mock_taskbar.xml b/quickstep/res/layout/gesture_tutorial_tablet_mock_taskbar.xml similarity index 100% rename from quickstep/res/layout/gesture_tutorial_foldable_mock_taskbar.xml rename to quickstep/res/layout/gesture_tutorial_tablet_mock_taskbar.xml diff --git a/quickstep/res/layout/gesture_tutorial_foldable_mock_webpage.xml b/quickstep/res/layout/gesture_tutorial_tablet_mock_webpage.xml similarity index 100% rename from quickstep/res/layout/gesture_tutorial_foldable_mock_webpage.xml rename to quickstep/res/layout/gesture_tutorial_tablet_mock_webpage.xml diff --git a/quickstep/res/values-land/dimens.xml b/quickstep/res/values-land/dimens.xml index 668aea2c9e..f233bde73a 100644 --- a/quickstep/res/values-land/dimens.xml +++ b/quickstep/res/values-land/dimens.xml @@ -16,4 +16,61 @@ --> 8dp + + + 126dp + 24dp + + + 42dp + 60dp + 42dp + 683dp + 42dp + 35dp + 2 + 505dp + 462dp + 103dp + 103dp + 345dp + 341dp + 501dp + 345dp + 373dp + + + 607dp + 460dp + 554dp + 517dp + 570dp + 336dp + 523dp + 500dp + 15dp + 72dp + 111dp + 2 + 34dp + 42dp + + + -2px + -1px + 170dp + + + 24dp + 48dp + 121dp + 355dp + 355dp + 208dp + 439dp + 311dp + 2 + + + 218dp \ No newline at end of file diff --git a/quickstep/res/values/dimens.xml b/quickstep/res/values/dimens.xml index 926e10c8b7..de6768909c 100644 --- a/quickstep/res/values/dimens.xml +++ b/quickstep/res/values/dimens.xml @@ -110,8 +110,10 @@ 136dp - 24dp - 140dp + 8dp + 140dp + 16dp + 24dp 72dp 18dp 80dp @@ -124,15 +126,46 @@ 4dp 26dp 18dp - 126dp + 34dp + 211dp + 24dp + 66dp + 0 + 124dp + 144dp + 34dp + 24dp + 126dp + 245dp + 241dp + 401dp + 245dp + 273dp 56dp 100dp 28dp 20dp + 217dp + 142dp + 190dp + 171dp + 198dp + 79dp + 174dp + 117dp + 65dp + 132dp + 161dp + 0 + 24dp + 66dp + -1px + -2px + 26dp 60dp 100dp 50dp @@ -148,11 +181,20 @@ 4dp 36dp 22dp + 16dp + 24dp + 97dp + 97dp + 126dp + 64dp + 151dp + 24dp + 0 44dp 100dp - 218dp + 52dp 40dp diff --git a/quickstep/res/values/strings.xml b/quickstep/res/values/strings.xml index 3ee2af0bed..f80deeba45 100644 --- a/quickstep/res/values/strings.xml +++ b/quickstep/res/values/strings.xml @@ -182,8 +182,10 @@ All set! Swipe up to go Home - + You\u2019re ready to start using your phone + + You\u2019re ready to start using your tablet System navigation settings diff --git a/quickstep/res/values/styles.xml b/quickstep/res/values/styles.xml index 2efe72e651..6aa488375b 100644 --- a/quickstep/res/values/styles.xml +++ b/quickstep/res/values/styles.xml @@ -47,6 +47,12 @@ 44sp + + + + @@ -76,9 +88,8 @@