PawletOS/Lawnchair
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Removing LauncherProvider dependency from LauncherSettings

Browse Source 
> This ensures that the classLoader does not need to load
LauncherProvider to access LauncherSettings
> Making a few fields public.

Change-Id: I2e8ee6e169552739f09e500d3b6acbcee7cd0718
This commit is contained in:
Sunny Goyal
2015-04-17 09:24:01 -07:00
parent fb9ca23928
commit 18b640c371
2 changed files with 22 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/com/android/launcher3/LauncherProvider.java
+2 -2
View File
@@ -69,8 +69,8 @@ public class LauncherProvider extends ContentProvider {
static final String OLD_AUTHORITY = "com.android.launcher2.settings";
static final String AUTHORITY = ProviderConfig.AUTHORITY;
static final String TABLE_FAVORITES = "favorites";
static final String TABLE_WORKSPACE_SCREENS = "workspaceScreens";
static final String TABLE_FAVORITES = LauncherSettings.Favorites.TABLE_NAME;
static final String TABLE_WORKSPACE_SCREENS = LauncherSettings.WorkspaceScreens.TABLE_NAME;
static final String EMPTY_DATABASE_CREATED = "EMPTY_DATABASE_CREATED";
private static final String URI_PARAM_IS_EXTERNAL_ADD = "isExternalAdd";
src/com/android/launcher3/LauncherSettings.java
+20 -12
View File
@@ -19,6 +19,8 @@ package com.android.launcher3;
import android.net.Uri;
import android.provider.BaseColumns;
import com.android.launcher3.config.ProviderConfig;
/**
* Settings related utilities.
*/
@@ -45,7 +47,7 @@ public class LauncherSettings {
* an Intent that can be launched.
* <P>Type: TEXT</P>
*/
static final String INTENT = "intent";
public static final String INTENT = "intent";
/**
* The type of the gesture
@@ -104,29 +106,35 @@ public class LauncherSettings {
*
* Tracks the order of workspace screens.
*/
static final class WorkspaceScreens implements ChangeLogColumns {
public static final class WorkspaceScreens implements ChangeLogColumns {
public static final String TABLE_NAME = "workspaceScreens";
/**
* The content:// style URL for this table
*/
static final Uri CONTENT_URI = Uri.parse("content://" +
LauncherProvider.AUTHORITY + "/" + LauncherProvider.TABLE_WORKSPACE_SCREENS);
ProviderConfig.AUTHORITY + "/" + TABLE_NAME);
/**
* The rank of this screen -- ie. how it is ordered relative to the other screens.
* <P>Type: INTEGER</P>
*/
static final String SCREEN_RANK = "screenRank";
public static final String SCREEN_RANK = "screenRank";
}
/**
* Favorites.
*/
public static final class Favorites implements BaseLauncherColumns {
public static final String TABLE_NAME = "favorites";
/**
* The content:// style URL for this table
*/
static final Uri CONTENT_URI = Uri.parse("content://" +
LauncherProvider.AUTHORITY + "/" + LauncherProvider.TABLE_FAVORITES);
public static final Uri CONTENT_URI = Uri.parse("content://" +
ProviderConfig.AUTHORITY + "/" + TABLE_NAME);
/**
* The content:// style URL for a given row, identified by its id.
@@ -136,21 +144,21 @@ public class LauncherSettings {
* @return The unique content URL for the specified row.
*/
static Uri getContentUri(long id) {
return Uri.parse("content://" + LauncherProvider.AUTHORITY +
"/" + LauncherProvider.TABLE_FAVORITES + "/" + id);
return Uri.parse("content://" + ProviderConfig.AUTHORITY +
"/" + TABLE_NAME + "/" + id);
}
/**
* The container holding the favorite
* <P>Type: INTEGER</P>
*/
static final String CONTAINER = "container";
public static final String CONTAINER = "container";
/**
* The icon is a resource identified by a package name and an integer id.
*/
static final int CONTAINER_DESKTOP = -100;
static final int CONTAINER_HOTSEAT = -101;
public static final int CONTAINER_DESKTOP = -100;
public static final int CONTAINER_HOTSEAT = -101;
static final String containerToString(int container) {
switch (container) {
@@ -164,7 +172,7 @@ public class LauncherSettings {
* The screen holding the favorite (if container is CONTAINER_DESKTOP)
* <P>Type: INTEGER</P>
*/
static final String SCREEN = "screen";
public static final String SCREEN = "screen";
/**
* The X coordinate of the cell holding the favorite