From 162a85e77763dd3f6aec282bbd01ea8d0de9c482 Mon Sep 17 00:00:00 2001
From: vinayjoglekar <vinayjoglekar@google.com>
Date: Sat, 22 Mar 2025 10:52:38 +0530
Subject: [PATCH] Remove unnecessary call to RecentsView.reset when switching
 from any non-overview state.

We were checking whether recents is visible or not while opening all
apps and calling RecentsView#reset. Since Recents is not visible, we
were always calling reset which was making additional blur. Adding check
here of what current state is, will reduce these calls.

Added perfetto traces comparison here

https://drive.google.com/drive/folders/146K_4WLaOGQcZ1gsuhCFlOCzfZ-mJBw8?resourcekey=0-r1-NnNtYGH88d8DGEvnXZg&usp=sharing

Bug: 404647629
Test: Manual. Launcher home -> all apps.
Flag: EXEMPT bugfix
Change-Id: If0e31638adee50d36974abd7a4c809e3747f37a0
---
 .../launcher3/uioverrides/RecentsViewStateController.kt        | 2 +-
 .../quickstep/fallback/FallbackRecentsStateController.java     | 3 ++-
 .../com/android/quickstep/fallback/FallbackRecentsView.java    | 2 +-
 .../src/com/android/quickstep/views/LauncherRecentsView.java   | 2 +-
 4 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/quickstep/src/com/android/launcher3/uioverrides/RecentsViewStateController.kt b/quickstep/src/com/android/launcher3/uioverrides/RecentsViewStateController.kt
index c9f791c6ee..1d0077fd8c 100644
--- a/quickstep/src/com/android/launcher3/uioverrides/RecentsViewStateController.kt
+++ b/quickstep/src/com/android/launcher3/uioverrides/RecentsViewStateController.kt
@@ -210,7 +210,7 @@ class RecentsViewStateController(private val launcher: QuickstepLauncher) :
         )
 
         builder.addEndListener { success: Boolean ->
-            if (!success && !toState.isRecentsViewVisible) {
+            if (!success && fromState.isRecentsViewVisible && !toState.isRecentsViewVisible) {
                 recentsView.reset()
             }
         }
diff --git a/quickstep/src/com/android/quickstep/fallback/FallbackRecentsStateController.java b/quickstep/src/com/android/quickstep/fallback/FallbackRecentsStateController.java
index 7db1813a90..a4c0d0328c 100644
--- a/quickstep/src/com/android/quickstep/fallback/FallbackRecentsStateController.java
+++ b/quickstep/src/com/android/quickstep/fallback/FallbackRecentsStateController.java
@@ -87,7 +87,8 @@ public class FallbackRecentsStateController implements StateHandler<RecentsState
         // While animating into recents, update the visible task data as needed
         setter.addOnFrameCallback(() -> mRecentsView.loadVisibleTaskData(FLAG_UPDATE_ALL));
         setter.addEndListener(success -> {
-            if (!success && !toState.isRecentsViewVisible()) {
+            if (!success && mRecentsViewContainer.isRecentsViewVisible()
+                    && !toState.isRecentsViewVisible()) {
                 mRecentsView.reset();
             }
         });
diff --git a/quickstep/src/com/android/quickstep/fallback/FallbackRecentsView.java b/quickstep/src/com/android/quickstep/fallback/FallbackRecentsView.java
index dc1cdde4bc..dcd7089d13 100644
--- a/quickstep/src/com/android/quickstep/fallback/FallbackRecentsView.java
+++ b/quickstep/src/com/android/quickstep/fallback/FallbackRecentsView.java
@@ -287,7 +287,7 @@ public class FallbackRecentsView<CONTAINER_TYPE extends Context & RecentsViewCon
                 setOverviewGridEnabled(false);
             }
         }
-        if (!finalState.isRecentsViewVisible()) {
+        if (mContainer.isRecentsViewVisible() && !finalState.isRecentsViewVisible()) {
             // Clean-up logic that occurs when recents is no longer in use/visible.
             reset();
         }
diff --git a/quickstep/src/com/android/quickstep/views/LauncherRecentsView.java b/quickstep/src/com/android/quickstep/views/LauncherRecentsView.java
index b86d0c85de..6ddba80126 100644
--- a/quickstep/src/com/android/quickstep/views/LauncherRecentsView.java
+++ b/quickstep/src/com/android/quickstep/views/LauncherRecentsView.java
@@ -184,7 +184,7 @@ public class LauncherRecentsView extends RecentsView<QuickstepLauncher, Launcher
             }
         }
 
-        if (!finalState.isRecentsViewVisible) {
+        if (mContainer.isRecentsViewVisible() && !finalState.isRecentsViewVisible) {
             // Clean-up logic that occurs when recents is no longer in use/visible.
             reset();
         }