From aa9bef2f31de8613b9ff6b4dd4ccb62189ad7991 Mon Sep 17 00:00:00 2001 From: Brian Isganitis Date: Mon, 15 May 2023 13:27:59 -0400 Subject: [PATCH] Cleanup WIDGETS_IN_LAUNCHER_PREVIEW. Test: Manual Fix: 270393268 Change-Id: I2d90f92c6bc85d59d56f5e6c2d6005554f932895 --- .../launcher3/config/FeatureFlags.java | 4 ---- .../graphics/LauncherPreviewRenderer.java | 20 +++---------------- 2 files changed, 3 insertions(+), 21 deletions(-) diff --git a/src/com/android/launcher3/config/FeatureFlags.java b/src/com/android/launcher3/config/FeatureFlags.java index 8dc120402d..de18776153 100644 --- a/src/com/android/launcher3/config/FeatureFlags.java +++ b/src/com/android/launcher3/config/FeatureFlags.java @@ -142,10 +142,6 @@ public final class FeatureFlags { "Enables haptics opening/closing All apps"); // TODO(Block 6): Clean up flags - public static final BooleanFlag WIDGETS_IN_LAUNCHER_PREVIEW = getDebugFlag(270393268, - "WIDGETS_IN_LAUNCHER_PREVIEW", ENABLED, - "Enables widgets in Launcher preview for the Wallpaper app."); - public static final BooleanFlag ENABLE_ALL_APPS_SEARCH_IN_TASKBAR = getDebugFlag(270393900, "ENABLE_ALL_APPS_SEARCH_IN_TASKBAR", DISABLED, "Enables Search box in Taskbar All Apps."); diff --git a/src/com/android/launcher3/graphics/LauncherPreviewRenderer.java b/src/com/android/launcher3/graphics/LauncherPreviewRenderer.java index b438e86bf8..47677eab8c 100644 --- a/src/com/android/launcher3/graphics/LauncherPreviewRenderer.java +++ b/src/com/android/launcher3/graphics/LauncherPreviewRenderer.java @@ -105,7 +105,6 @@ import com.android.launcher3.widget.BaseLauncherAppWidgetHostView; import com.android.launcher3.widget.LauncherAppWidgetProviderInfo; import com.android.launcher3.widget.LauncherWidgetHolder; import com.android.launcher3.widget.LocalColorExtractor; -import com.android.launcher3.widget.NavigableAppWidgetHostView; import com.android.launcher3.widget.custom.CustomWidgetManager; import com.android.launcher3.widget.util.WidgetSizes; @@ -281,9 +280,7 @@ public class LauncherPreviewRenderer extends ContextWrapper } else { mWallpaperColorResources = null; } - mAppWidgetHost = FeatureFlags.WIDGETS_IN_LAUNCHER_PREVIEW.get() - ? new LauncherPreviewAppWidgetHost(context) - : null; + mAppWidgetHost = new LauncherPreviewAppWidgetHost(context); } /** Populate preview and render it. */ @@ -416,19 +413,8 @@ public class LauncherPreviewRenderer extends ContextWrapper private void inflateAndAddWidgets( LauncherAppWidgetInfo info, LauncherAppWidgetProviderInfo providerInfo) { - AppWidgetHostView view; - if (FeatureFlags.WIDGETS_IN_LAUNCHER_PREVIEW.get()) { - view = mAppWidgetHost.createView(mContext, info.appWidgetId, providerInfo); - } else { - view = new NavigableAppWidgetHostView(this) { - @Override - protected boolean shouldAllowDirectClick() { - return false; - } - }; - view.setAppWidget(-1, providerInfo); - view.updateAppWidget(null); - } + AppWidgetHostView view = mAppWidgetHost.createView( + mContext, info.appWidgetId, providerInfo); if (mWallpaperColorResources != null) { view.setColorResources(mWallpaperColorResources);