From 07546b88e72d6251f63b04f654afd2d0c3f613b9 Mon Sep 17 00:00:00 2001 From: Kevin Lim Date: Mon, 25 Sep 2023 21:02:56 +0000 Subject: [PATCH] [AppInfo] Enable logs for debugging unexpected AppInfo changes. Here's a sample log run through of AllAppsStore and PackageUpdatedTask logs: http://gpaste/5250747917664256 Bug: b/290090023 Flag: None. Adding logging. Test: None. Adding logging. Change-Id: Ia1d620a50267d6a65fe719936d7e87e6dad13afa --- src/com/android/launcher3/Launcher.java | 1 + src/com/android/launcher3/allapps/AllAppsStore.java | 10 ++++++++++ .../android/launcher3/model/PackageUpdatedTask.java | 4 ++-- 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/src/com/android/launcher3/Launcher.java b/src/com/android/launcher3/Launcher.java index 4215e3111f..2b433f152c 100644 --- a/src/com/android/launcher3/Launcher.java +++ b/src/com/android/launcher3/Launcher.java @@ -2988,6 +2988,7 @@ public class Launcher extends StatefulActivity mStateManager.dump(prefix, writer); mPopupDataProvider.dump(prefix, writer); mDeviceProfile.dump(this, prefix, writer); + mAppsView.getAppsStore().dump(prefix, writer); try { FileLog.flushAll(writer); diff --git a/src/com/android/launcher3/allapps/AllAppsStore.java b/src/com/android/launcher3/allapps/AllAppsStore.java index 378dbf3faf..7867f44a2f 100644 --- a/src/com/android/launcher3/allapps/AllAppsStore.java +++ b/src/com/android/launcher3/allapps/AllAppsStore.java @@ -37,6 +37,7 @@ import com.android.launcher3.util.ComponentKey; import com.android.launcher3.util.PackageUserKey; import com.android.launcher3.views.ActivityContext; +import java.io.PrintWriter; import java.util.ArrayList; import java.util.Arrays; import java.util.Collections; @@ -238,4 +239,13 @@ public class AllAppsStore { public interface OnUpdateListener { void onAppsUpdated(); } + + /** Generate a dumpsys for each app package name and position in the apps list */ + public void dump(String prefix, PrintWriter writer) { + writer.println(prefix + "\tAllAppsStore Apps[] size: " + mApps.length); + for (int i = 0; i < mApps.length; i++) { + writer.println(String.format("%s\tPackage index and name: %d/%s", prefix, i, + mApps[i].componentName.getPackageName())); + } + } } diff --git a/src/com/android/launcher3/model/PackageUpdatedTask.java b/src/com/android/launcher3/model/PackageUpdatedTask.java index 1917ba23df..37a717145a 100644 --- a/src/com/android/launcher3/model/PackageUpdatedTask.java +++ b/src/com/android/launcher3/model/PackageUpdatedTask.java @@ -44,7 +44,6 @@ import com.android.launcher3.model.data.WorkspaceItemInfo; import com.android.launcher3.pm.PackageInstallInfo; import com.android.launcher3.pm.UserCache; import com.android.launcher3.shortcuts.ShortcutRequest; -import com.android.launcher3.testing.shared.TestProtocol; import com.android.launcher3.util.FlagOp; import com.android.launcher3.util.IntSet; import com.android.launcher3.util.ItemInfoMatcher; @@ -68,7 +67,8 @@ import java.util.stream.Collectors; */ public class PackageUpdatedTask extends BaseModelUpdateTask { - private static boolean DEBUG = false; + // TODO(b/290090023): Set to false after root causing is done. + private static final boolean DEBUG = true; private static final String TAG = "PackageUpdatedTask"; public static final int OP_NONE = 0;