diff --git a/quickstep/src/com/android/launcher3/statehandlers/DesktopVisibilityController.java b/quickstep/src/com/android/launcher3/statehandlers/DesktopVisibilityController.java index 176091a141..c0dacf1daa 100644 --- a/quickstep/src/com/android/launcher3/statehandlers/DesktopVisibilityController.java +++ b/quickstep/src/com/android/launcher3/statehandlers/DesktopVisibilityController.java @@ -48,7 +48,7 @@ public class DesktopVisibilityController { "persist.wm.debug.desktop_stashing", false); private final Launcher mLauncher; - private int mVisibleFreeformTasksCount; + private int mVisibleDesktopTasksCount; private boolean mInOverviewState; private boolean mBackgroundStateEnabled; private boolean mGestureInProgress; @@ -73,7 +73,7 @@ public class DesktopVisibilityController { if (DEBUG) { Log.d(TAG, "desktop visible tasks count changed=" + visibleTasksCount); } - setVisibleFreeformTasksCount(visibleTasksCount); + setVisibleDesktopTasksCount(visibleTasksCount); } }); } @@ -108,51 +108,51 @@ public class DesktopVisibilityController { } /** - * Whether freeform windows are visible in desktop mode. + * Whether desktop tasks are visible in desktop mode. */ - public boolean areFreeformTasksVisible() { - boolean freeformTasksVisible = mVisibleFreeformTasksCount > 0; + public boolean areDesktopTasksVisible() { + boolean desktopTasksVisible = mVisibleDesktopTasksCount > 0; if (DEBUG) { - Log.d(TAG, "areFreeformTasksVisible: freeformVisible=" + freeformTasksVisible + Log.d(TAG, "areDesktopTasksVisible: desktopVisible=" + desktopTasksVisible + " overview=" + mInOverviewState); } - return freeformTasksVisible && !mInOverviewState; + return desktopTasksVisible && !mInOverviewState; } /** - * Number of visible freeform windows in desktop mode. + * Number of visible desktop windows in desktop mode. */ - public int getVisibleFreeformTasksCount() { - return mVisibleFreeformTasksCount; + public int getVisibleDesktopTasksCount() { + return mVisibleDesktopTasksCount; } /** - * Sets the number of freeform windows that are visible and updates launcher visibility based on + * Sets the number of desktop windows that are visible and updates launcher visibility based on * it. */ - public void setVisibleFreeformTasksCount(int visibleTasksCount) { + public void setVisibleDesktopTasksCount(int visibleTasksCount) { if (DEBUG) { - Log.d(TAG, "setVisibleFreeformTasksCount: visibleTasksCount=" + visibleTasksCount - + " currentValue=" + mVisibleFreeformTasksCount); + Log.d(TAG, "setVisibleDesktopTasksCount: visibleTasksCount=" + visibleTasksCount + + " currentValue=" + mVisibleDesktopTasksCount); } - if (visibleTasksCount != mVisibleFreeformTasksCount) { - final boolean wasVisible = mVisibleFreeformTasksCount > 0; + if (visibleTasksCount != mVisibleDesktopTasksCount) { + final boolean wasVisible = mVisibleDesktopTasksCount > 0; final boolean isVisible = visibleTasksCount > 0; - mVisibleFreeformTasksCount = visibleTasksCount; + mVisibleDesktopTasksCount = visibleTasksCount; if (wasVisible != isVisible) { - if (mVisibleFreeformTasksCount > 0) { + if (mVisibleDesktopTasksCount > 0) { setLauncherViewsVisibility(View.INVISIBLE); if (!mInOverviewState) { - // When freeform is visible & we're not in overview, we want launcher to - // appear paused, this ensures that taskbar displays. + // When desktop tasks are visible & we're not in overview, we want launcher + // to appear paused, this ensures that taskbar displays. markLauncherPaused(); } } else { setLauncherViewsVisibility(View.VISIBLE); - // If freeform isn't visible ensure that launcher appears resumed to behave - // normally. + // If desktop tasks aren't visible, ensure that launcher appears resumed to + // behave normally. markLauncherResumed(); } } @@ -181,9 +181,9 @@ public class DesktopVisibilityController { if (mInOverviewState) { setLauncherViewsVisibility(View.VISIBLE); markLauncherResumed(); - } else if (areFreeformTasksVisible() && !mGestureInProgress) { + } else if (areDesktopTasksVisible() && !mGestureInProgress) { // Switching out of overview state and gesture finished. - // If freeform tasks are still visible, hide launcher again. + // If desktop tasks are still visible, hide launcher again. setLauncherViewsVisibility(View.INVISIBLE); markLauncherPaused(); } @@ -200,8 +200,8 @@ public class DesktopVisibilityController { if (mBackgroundStateEnabled) { setLauncherViewsVisibility(View.VISIBLE); markLauncherResumed(); - } else if (areFreeformTasksVisible() && !mGestureInProgress) { - // Switching out of background state. If freeform tasks are visible, pause launcher. + } else if (areDesktopTasksVisible() && !mGestureInProgress) { + // Switching out of background state. If desktop tasks are visible, pause launcher. setLauncherViewsVisibility(View.INVISIBLE); markLauncherPaused(); } @@ -251,7 +251,7 @@ public class DesktopVisibilityController { * Handle launcher moving to home due to home gesture or home button press. */ public void onHomeActionTriggered() { - if (IS_STASHING_ENABLED && areFreeformTasksVisible()) { + if (IS_STASHING_ENABLED && areDesktopTasksVisible()) { SystemUiProxy.INSTANCE.get(mLauncher).stashDesktopApps(mLauncher.getDisplayId()); } } @@ -270,7 +270,7 @@ public class DesktopVisibilityController { dragLayer.setVisibility(visibility); } if (mLauncher instanceof QuickstepLauncher ql && ql.getTaskbarUIController() != null - && mVisibleFreeformTasksCount != 0) { + && mVisibleDesktopTasksCount != 0) { ql.getTaskbarUIController().onLauncherVisibilityChanged(visibility == VISIBLE); } } diff --git a/quickstep/src/com/android/launcher3/taskbar/KeyboardQuickSwitchController.java b/quickstep/src/com/android/launcher3/taskbar/KeyboardQuickSwitchController.java index d89f49b6aa..584106bc05 100644 --- a/quickstep/src/com/android/launcher3/taskbar/KeyboardQuickSwitchController.java +++ b/quickstep/src/com/android/launcher3/taskbar/KeyboardQuickSwitchController.java @@ -115,7 +115,7 @@ public final class KeyboardQuickSwitchController implements DesktopVisibilityController desktopController = LauncherActivityInterface.INSTANCE.getDesktopVisibilityController(); final boolean onDesktop = - desktopController != null && desktopController.areFreeformTasksVisible(); + desktopController != null && desktopController.areDesktopTasksVisible(); if (mModel.isTaskListValid(mTaskListChangeId)) { // When we are opening the KQS with no focus override, check if the first task is diff --git a/quickstep/src/com/android/launcher3/taskbar/LauncherTaskbarUIController.java b/quickstep/src/com/android/launcher3/taskbar/LauncherTaskbarUIController.java index 896cc8424b..03c28053c1 100644 --- a/quickstep/src/com/android/launcher3/taskbar/LauncherTaskbarUIController.java +++ b/quickstep/src/com/android/launcher3/taskbar/LauncherTaskbarUIController.java @@ -219,7 +219,7 @@ public class LauncherTaskbarUIController extends TaskbarUIController { DesktopVisibilityController desktopController = LauncherActivityInterface.INSTANCE.getDesktopVisibilityController(); final boolean onDesktop = - desktopController != null && desktopController.areFreeformTasksVisible(); + desktopController != null && desktopController.areDesktopTasksVisible(); if (onDesktop) { isVisible = false; } @@ -433,7 +433,7 @@ public class LauncherTaskbarUIController extends TaskbarUIController { protected boolean canToggleHomeAllApps() { return mLauncher.isResumed() && !mTaskbarLauncherStateController.isInOverviewUi() - && !mLauncher.areFreeformTasksVisible(); + && !mLauncher.areDesktopTasksVisible(); } @Override diff --git a/quickstep/src/com/android/launcher3/taskbar/TaskbarStashController.java b/quickstep/src/com/android/launcher3/taskbar/TaskbarStashController.java index 7e74c27264..15be8e7415 100644 --- a/quickstep/src/com/android/launcher3/taskbar/TaskbarStashController.java +++ b/quickstep/src/com/android/launcher3/taskbar/TaskbarStashController.java @@ -985,7 +985,7 @@ public class TaskbarStashController implements TaskbarControllers.LoggableTaskba DesktopVisibilityController visibilityController = LauncherActivityInterface.INSTANCE.getDesktopVisibilityController(); if (visibilityController != null && mActivity.isHardwareKeyboard() - && mActivity.isThreeButtonNav() && visibilityController.areFreeformTasksVisible()) { + && mActivity.isThreeButtonNav() && visibilityController.areDesktopTasksVisible()) { return false; } diff --git a/quickstep/src/com/android/launcher3/uioverrides/QuickstepLauncher.java b/quickstep/src/com/android/launcher3/uioverrides/QuickstepLauncher.java index c5c009210f..6013797955 100644 --- a/quickstep/src/com/android/launcher3/uioverrides/QuickstepLauncher.java +++ b/quickstep/src/com/android/launcher3/uioverrides/QuickstepLauncher.java @@ -937,7 +937,7 @@ public class QuickstepLauncher extends Launcher { @Override public void setResumed() { if (mDesktopVisibilityController != null - && mDesktopVisibilityController.areFreeformTasksVisible() + && mDesktopVisibilityController.areDesktopTasksVisible() && !mDesktopVisibilityController.isRecentsGestureInProgress()) { // Return early to skip setting activity to appear as resumed // TODO(b/255649902): shouldn't be needed when we have a separate launcher state @@ -1284,9 +1284,9 @@ public class QuickstepLauncher extends Launcher { } @Override - public boolean areFreeformTasksVisible() { + public boolean areDesktopTasksVisible() { if (mDesktopVisibilityController != null) { - return mDesktopVisibilityController.areFreeformTasksVisible(); + return mDesktopVisibilityController.areDesktopTasksVisible(); } return false; } diff --git a/quickstep/src/com/android/launcher3/uioverrides/states/BackgroundAppState.java b/quickstep/src/com/android/launcher3/uioverrides/states/BackgroundAppState.java index 547de77f64..3ffad70365 100644 --- a/quickstep/src/com/android/launcher3/uioverrides/states/BackgroundAppState.java +++ b/quickstep/src/com/android/launcher3/uioverrides/states/BackgroundAppState.java @@ -91,8 +91,8 @@ public class BackgroundAppState extends OverviewState { @Override protected float getDepthUnchecked(Context context) { - if (Launcher.getLauncher(context).areFreeformTasksVisible()) { - // Don't blur the background while freeform tasks are visible + if (Launcher.getLauncher(context).areDesktopTasksVisible()) { + // Don't blur the background while desktop tasks are visible return BaseDepthController.DEPTH_0_PERCENT; } else if (enableScalingRevealHomeAnimation()) { return BaseDepthController.DEPTH_70_PERCENT; diff --git a/quickstep/src/com/android/launcher3/uioverrides/states/QuickSwitchState.java b/quickstep/src/com/android/launcher3/uioverrides/states/QuickSwitchState.java index 7fb811d4b7..dfad4096bc 100644 --- a/quickstep/src/com/android/launcher3/uioverrides/states/QuickSwitchState.java +++ b/quickstep/src/com/android/launcher3/uioverrides/states/QuickSwitchState.java @@ -45,8 +45,8 @@ public class QuickSwitchState extends BackgroundAppState { @Override public int getWorkspaceScrimColor(Launcher launcher) { - if (launcher.areFreeformTasksVisible()) { - // No scrim while freeform tasks are visible + if (launcher.areDesktopTasksVisible()) { + // No scrim while desktop tasks are visible return Color.TRANSPARENT; } DeviceProfile dp = launcher.getDeviceProfile(); diff --git a/quickstep/src/com/android/quickstep/BaseActivityInterface.java b/quickstep/src/com/android/quickstep/BaseActivityInterface.java index a3f6be032b..a3a5f82bdd 100644 --- a/quickstep/src/com/android/quickstep/BaseActivityInterface.java +++ b/quickstep/src/com/android/quickstep/BaseActivityInterface.java @@ -109,12 +109,12 @@ public abstract class BaseActivityInterface 0) { // Allocate +1 to account for a new task added to the desktop mode int numHandles = visibleTasksCount + 1; diff --git a/quickstep/src/com/android/quickstep/views/LauncherRecentsView.java b/quickstep/src/com/android/quickstep/views/LauncherRecentsView.java index 0a3d2a0ac1..352ebfe7b0 100644 --- a/quickstep/src/com/android/quickstep/views/LauncherRecentsView.java +++ b/quickstep/src/com/android/quickstep/views/LauncherRecentsView.java @@ -271,7 +271,7 @@ public class LauncherRecentsView extends RecentsView * Returns {@code true} if there are visible tasks with windowing mode set to * {@link android.app.WindowConfiguration#WINDOWING_MODE_FREEFORM} */ - public boolean areFreeformTasksVisible() { - return false; // Base launcher does not track freeform tasks + public boolean areDesktopTasksVisible() { + return false; // Base launcher does not track desktop tasks } // Getters and Setters