TESTS TESTS ADDED MORE TEST TESTED GRESOURCES TESTS TESTS I LOVE TESTS SO MUCH

- Fully covered gresource orchestrator and it helpers with tests
- Use abstract command runner INSTEAD OF SUBPROCESS in gresources
- Replaced some subprocesses by builtin functions

scripts/utils/gresource/gresource_extractor.py

@@ -1,45 +1,48 @@
 import os
-import subprocess
 
+from scripts.utils.command_runner.command_runner import CommandRunner
 from scripts.utils.gresource import raise_gresource_error
 from scripts.utils.logger.logger import LoggerFactory
 
 
 class GresourceExtractor:
-    def __init__(self, gresource_path: str, extract_folder: str, logger_factory: LoggerFactory):
+    def __init__(
+            self, gresource_path: str, extract_folder: str,
+            logger_factory: LoggerFactory, runner: CommandRunner
+    ):
         self.gresource_path = gresource_path
         self.extract_folder = extract_folder
         self.logger_factory = logger_factory
+        self.runner = runner
 
     def extract(self):
         extract_line = self.logger_factory.create_logger()
         extract_line.update("Extracting gresource files...")
 
-        resources = self._get_resources_list()
-        self._extract_resources(resources)
+        self._try_extract_resources()
 
         extract_line.success("Extracted gresource files.")
 
-    def _get_resources_list(self):
-        resources_list_response = subprocess.run(
-            ["gresource", "list", self.gresource_path],
-            capture_output=True, text=True, check=False
-        )
-
-        if resources_list_response.stderr:
-            raise Exception(f"gresource could not process the theme file: {self.gresource_path}")
-
-        return resources_list_response.stdout.strip().split("\n")
-
-    def _extract_resources(self, resources: list[str]):
+    def _try_extract_resources(self):
         try:
-            self._try_extract_resources(resources)
+            resources = self._get_resources_list()
+            self._extract_resources(resources)
         except FileNotFoundError as e:
+            print(e)
             if "gresource" in str(e):
                 raise_gresource_error("gresource", e)
             raise
+        except Exception as e:
+            raise Exception(f"gresource could not process the theme file: {self.gresource_path}") from e
 
-    def _try_extract_resources(self, resources: list[str]):
+    def _get_resources_list(self):
+        resources_list_response = self.runner.run(
+            ["gresource", "list", self.gresource_path],
+            capture_output=True, text=True, check=True
+        )
+        return resources_list_response.stdout.strip().split("\n")
+
+    def _extract_resources(self, resources: list[str]):
         prefix = "/org/gnome/shell/theme/"
         for resource in resources:
             resource_path = resource.replace(prefix, "")
@@ -47,7 +50,7 @@ class GresourceExtractor:
             os.makedirs(os.path.dirname(output_path), exist_ok=True)
 
             with open(output_path, 'wb') as f:
-                subprocess.run(
+                self.runner.run(
                     ["gresource", "extract", self.gresource_path, resource],
                     stdout=f, check=True
                 )